-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect stdout for mise shell function in xonsh #1862
base: main
Are you sure you want to change the base?
Conversation
dceea0b
to
5963167
Compare
I think it'd be better if we just found out why CLICOLOR_FORCE isn't working and fixed that directly |
The coloring problem is only a side-effect of this fix, so it should imho have no bearing on whether this fix should be accepted or not. The fix addresses stdio within the xonsh shell which I handled incorrectly, thereby breaking pipe-ability. You can read about that here: xonsh/xonsh#5316 |
fad123b
to
d13511e
Compare
5963167
to
b085fce
Compare
b085fce
to
104c14a
Compare
I'd like to be able to fix the xonsh piping issue without regressing on color output. |
I'd rather have a functionally working shell incl. pipeability than colours, nice though they may be. That the colours work at all in xonsh with the current code is a mere accident and side effect of my buggy original implementation. |
104c14a
to
081ddde
Compare
The old implementation had issues with piping the result since stdout/stderr was not acutally captured in the shell but directly printed to the terminal. The fix here unfortunately effectivly turns off colors in mise, as mise seems to not honor CLICOLOR_FORCE et. al. environment variables as per jdx#1836
081ddde
to
5cdd026
Compare
The old implementation had issues with piping the result since stdout/stderr was not acutally captured in the shell but directly printed to the terminal.
The fix here unfortunately effectivly turns off colors in mise, as mise seems to not honor CLICOLOR_FORCE et. al. environment variables as per #1836