Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completions: fix some issues with zsh completions #1080

Merged
merged 1 commit into from
Dec 5, 2023
Merged

completions: fix some issues with zsh completions #1080

merged 1 commit into from
Dec 5, 2023

Conversation

jdx
Copy link
Owner

@jdx jdx commented Dec 5, 2023

Fixes #1079

@jdx jdx changed the title completions: fix zsh completions when sourced directly completions: fix some issues with zsh completions Dec 5, 2023
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (95c78ed) 86.36% compared to head (96edced) 83.68%.

Files Patch % Lines
src/cli/render_completion.rs 95.06% 8 Missing ⚠️
src/cli/plugins/uninstall.rs 62.50% 3 Missing ⚠️
src/cli/alias/ls.rs 80.00% 1 Missing ⚠️
src/cli/plugins/ls.rs 50.00% 1 Missing ⚠️
src/cli/plugins/mod.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1080      +/-   ##
==========================================
- Coverage   86.36%   83.68%   -2.69%     
==========================================
  Files         134      134              
  Lines       12589    12675      +86     
==========================================
- Hits        10873    10607     -266     
- Misses       1716     2068     +352     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This makes `eval "$(rtx completion zsh)"` work again.

Fixes #1079
@jdx jdx enabled auto-merge (squash) December 5, 2023 20:39
@jdx jdx merged commit 7b91d99 into main Dec 5, 2023
14 of 15 checks passed
@jdx jdx deleted the fix-zsh branch December 5, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zsh completions broken
1 participant