fix(plugin): fix issue with aria-hidden visualization

jdan · May 19, 2019 · b3a2c38 · b3a2c38
1 parent a7a728a
commit b3a2c38
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 20 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/plugins/aria-visualizer/index.js b/plugins/aria-visualizer/index.js
@@ -50,19 +50,16 @@ class AriaVisualizer extends Plugin {
     }
 
     startAriaHidden(attribute) {
-        const ariaName = `aria-${attribute}`;
-
-        [...document.querySelectorAll(`[${ariaName}="true"]:not(.tota11y)`)].forEach((element) => {
+        [...document.querySelectorAll(`[${attribute}="true"]:not(.tota11y)`)].forEach((element) => {
+            console.log(element);
             if (!element.closest(".tota11y")) {
-                element.classList.add(`tota11y-${ariaName}-visualized`);
+                element.classList.add(`tota11y-${attribute}-visualized`);
             }
         });
     }
 
     stopAriaHidden(attribute) {
-        const ariaName = `aria-${attribute}`;
-
-        const className = `tota11y-${ariaName}-visualized`;
+        const className = `tota11y-${attribute}-visualized`;
 
         [...document.querySelectorAll(`.${className}`)].forEach((element) => {
             element.classList.remove(className);

diff --git a/test/index.html b/test/index.html
@@ -62,8 +62,8 @@ <h1>Hello, world!</h1>
 
             <article id="article">
                 <p>This paragraph is visible.</p>
-                <p id="p-with-hidden">This paragraph has a <span id="span" aria-hidden="true">hidden</span> span.</p>
-                <p id="hidden-p" aria-hidden="true">This paragraph is hidden.</p>
+                <p id="p-with-hidden">This paragraph has an <span id="span" aria-hidden="true">aria-hidden</span> span.</p>
+                <p id="hidden-p" aria-hidden="true">This paragraph is aria-hidden.</p>
             </article>
 
             <p>