Build Python 3.13 wheels (not free-threaded) #711

edgarrmondragon · 2024-07-13T06:55:27Z

I can close this if #703 gets more attention, but I've confirmed changes here allow the wheels to be built in 3.8-3.13, and all tests are passing.

This warning is currently raised, but fixing it might be beyond the scope of this PR:

PytestUnraisableExceptionWarning: Exception ignored in PyDict_GetItem(); consider using PyDict_GetItemRef() or PyDict_GetItemWithError(): None

python/cpython#106004

edgarrmondragon

I think this is ready for an initial review.

Mostly followed advice from

.github/workflows/ci.yml

edgarrmondragon · 2024-07-13T07:04:21Z

msgspec/_utils.py

@@ -127,6 +127,7 @@ def get_class_annotations(obj):
                value = type(None)
            elif isinstance(value, str):
                value = _forward_ref(value)
+            # TODO: Pass `type_params` to `_eval_type` to fix deprecation warning


This missing parameter is causing a ton of warnings like this:

msgspec/_utils.py:130: DeprecationWarning: Failing to pass a value to the 'type_params' parameter of 'typing._eval_type' is deprecated, as it leads to incorrect behaviour when calling typing._eval_type on a stringified annotation that references a PEP 695 type parameter. It will be disallowed in Python 3.15.

python/cpython#118418

edgarrmondragon · 2024-07-13T19:45:15Z

This warning is currently raised but fixing it might be beyond the scope of this PR to fix it:
PytestUnraisableExceptionWarning: Exception ignored in PyDict_GetItem(); consider using PyDict_GetItemRef() or PyDict_GetItemWithError(): None

FWIW I think this is hiding an actual error:

PytestUnraisableExceptionWarning: Exception ignored in PyDict_GetItem(); consider using PyDict_GetItemRef() or PyDict_GetItemWithError(): None
    
    Traceback (most recent call last):
      File "/opt/_internal/cpython-3.13.0b3/lib/python3.13/typing.py", line 2251, in __hash__
        return hash((self.__origin__, self.__metadata__))
    TypeError: unhashable type: 'set'
    
      warnings.warn(pytest.PytestUnraisableExceptionWarning(msg))

in

msgspec/tests/test_inspect.py

Lines 790 to 793 in 2c37da0

    
           def test_inspect_with_unhashable_metadata(): 
        
               typ = Annotated[int, {"unhashable"}] 
        
               assert mi.type_info(typ) == mi.IntType()

edgarrmondragon · 2024-07-13T19:46:34Z

.github/workflows/ci.yml

@@ -99,10 +100,11 @@ jobs:
      - name: Set up Environment
        if: github.event_name != 'release'
        run: |
-            echo "CIBW_SKIP=${CIBW_SKIP} *-musllinux_* cp38-*_aarch64 cp39-*_aarch64 cp311-*_aarch64 cp312-*_aarch64" >> $GITHUB_ENV
+            echo "CIBW_BUILD=${CIBW_BUILD} cp313-*" >> $GITHUB_ENV


For the moment 3.13 wheels will only be built for non-release workflows.

☝️ Outdated with the release of Python 3.13.0rc1 since we want to start publishing cp313-* wheels now.

edgarrmondragon · 2024-07-21T17:39:51Z

macos-11 runners aren't available anymore, so I updated it to macos-14 in 748f4bb.

https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/#macos-11-deprecation-and-removal

edgarrmondragon · 2024-07-21T17:48:19Z

macos-11 runners aren't available anymore, so I updated it to macos-14 in 748f4bb.

https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/#macos-11-deprecation-and-removal

With that change, the wheels are finally built instead of the workflow getting stuck forever:

 12 wheels produced in 5 minutes:
  msgspec-0+untagged.1.g766a8f7-cp310-cp310-macosx_10_9_x86_64.whl    186 kB
  msgspec-0+untagged.1.g766a8f7-cp310-cp310-macosx_11_0_arm64.whl     180 kB
  msgspec-0+untagged.1.g766a8f7-cp311-cp311-macosx_10_9_x86_64.whl    184 kB
  msgspec-0+untagged.1.g766a8f7-cp311-cp311-macosx_11_0_arm64.whl     178 kB
  msgspec-0+untagged.1.g766a8f7-cp312-cp312-macosx_10_9_x86_64.whl    186 kB
  msgspec-0+untagged.1.g766a8f7-cp312-cp312-macosx_11_0_arm64.whl     180 kB
  msgspec-0+untagged.1.g766a8f7-cp313-cp313-macosx_10_13_x86_64.whl   186 kB
  msgspec-0+untagged.1.g766a8f7-cp313-cp313-macosx_11_0_arm64.whl     180 kB
  msgspec-0+untagged.1.g766a8f7-cp38-cp38-macosx_10_9_x86_64.whl      186 kB
  msgspec-0+untagged.1.g766a8f7-cp38-cp38-macosx_11_0_arm64.whl       180 kB
  msgspec-0+untagged.1.g766a8f7-cp39-cp39-macosx_10_9_x86_64.whl      186 kB
  msgspec-0+untagged.1.g766a8f7-cp39-cp39-macosx_11_0_arm64.whl       180 kB

https://github.com/edgarrmondragon/msgspec/actions/runs/10030128227/job/27719084757

tacaswell · 2024-07-25T16:26:03Z

I can also get msgspec to build with py313 with this branch, but not the branch in #703

edgarrmondragon · 2024-07-30T19:09:38Z

@jcrist This is ready for review at your convenience :)

edgarrmondragon · 2024-08-06T14:45:40Z

Updated to use Python 3.13.0rc1

edgarrmondragon · 2024-09-17T03:25:34Z

Updated to use Python 3.13.0rc2

ofek · 2024-09-18T12:56:37Z

@jcrist Can you please run the CI?

edgarrmondragon force-pushed the py313 branch 2 times, most recently from 9dbeea3 to dfca216 Compare July 13, 2024 07:02

Build Python 3.13 wheels (not free-threaded)

58a7826

edgarrmondragon force-pushed the py313 branch from dfca216 to 58a7826 Compare July 13, 2024 07:03

edgarrmondragon commented Jul 13, 2024

View reviewed changes

edgarrmondragon marked this pull request as ready for review July 13, 2024 07:08

edgarrmondragon added 2 commits July 13, 2024 12:09

Include cp313 wheels for testing

ca4ebf0

Build Python 3.13 wheels only for testing

e1d6dad

Remove trove classifier

94d7b73

edgarrmondragon commented Jul 13, 2024

View reviewed changes

edgarrmondragon mentioned this pull request Jul 15, 2024

chore: 3.13 support #703

Closed

Use macos-14 because macos-11 is not available anymore

748f4bb

edgarrmondragon mentioned this pull request Aug 6, 2024

3.13 support #698

Open

Update for Python 3.13.0rc1

649c0da

Clean up

6e4a86e

This was referenced Aug 18, 2024

Install and run pytype on Windows and Python 3.12 python/typeshed#12547

Closed

Please update for Python 3.12. google/pytype#1475

Open

Bump cibuildwheel to 2.21.1

8f03317

edgarrmondragon force-pushed the py313 branch from 1aff991 to 8f03317 Compare September 17, 2024 03:23

edgarrmondragon added 2 commits September 16, 2024 21:34

Upgrade deprecated artifact actions

105cb34

Fix types

3bba306

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build Python 3.13 wheels (not free-threaded) #711

Build Python 3.13 wheels (not free-threaded) #711

edgarrmondragon commented Jul 13, 2024 •

edited

Loading

edgarrmondragon left a comment

edgarrmondragon Jul 13, 2024 •

edited

Loading

edgarrmondragon commented Jul 13, 2024 •

edited

Loading

edgarrmondragon Jul 13, 2024

edgarrmondragon Aug 6, 2024

edgarrmondragon commented Jul 21, 2024

edgarrmondragon commented Jul 21, 2024

tacaswell commented Jul 25, 2024

edgarrmondragon commented Jul 30, 2024

edgarrmondragon commented Aug 6, 2024

edgarrmondragon commented Sep 17, 2024

ofek commented Sep 18, 2024

Build Python 3.13 wheels (not free-threaded) #711

Are you sure you want to change the base?

Build Python 3.13 wheels (not free-threaded) #711

Conversation

edgarrmondragon commented Jul 13, 2024 • edited Loading

edgarrmondragon left a comment

Choose a reason for hiding this comment

edgarrmondragon Jul 13, 2024 • edited Loading

Choose a reason for hiding this comment

edgarrmondragon commented Jul 13, 2024 • edited Loading

edgarrmondragon Jul 13, 2024

Choose a reason for hiding this comment

edgarrmondragon Aug 6, 2024

Choose a reason for hiding this comment

edgarrmondragon commented Jul 21, 2024

edgarrmondragon commented Jul 21, 2024

tacaswell commented Jul 25, 2024

edgarrmondragon commented Jul 30, 2024

edgarrmondragon commented Aug 6, 2024

edgarrmondragon commented Sep 17, 2024

ofek commented Sep 18, 2024

edgarrmondragon commented Jul 13, 2024 •

edited

Loading

edgarrmondragon Jul 13, 2024 •

edited

Loading

edgarrmondragon commented Jul 13, 2024 •

edited

Loading