Adds recursive lookup for ClassLoader.defineClass() and unit tests #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrille-artho
approved these changes
Aug 22, 2023
|
LGTM, but it is not easy to see if all patches have been integrated correctly due to the size of this combined PR. @pparizek , please check also. |
|
I agree with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @cyrille-artho and @pparizek,
This PR combines a set of related patches which add functionality and fix bugs. The patches involved here are #203, #208, #209 and #388, which means #410 can now be skipped as it is same as #388 minus the unit test in
ClassLoaderTest.The patch adds a total of 6 unit tests. All 1002 tests now pass.
Some refactors were necessary in the
build.gradlefile to comply the added dependency for asm and the task with the latest gradle version.Thanks!