Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply patch for #177 to add JPF example ConcurrentCount #412

Closed
wants to merge 1 commit into from

Conversation

varad64
Copy link
Contributor

@varad64 varad64 commented Aug 17, 2023

No new tests added.

@cyrille-artho
Copy link
Member

Actually, when reviewing this again, I can see that the program is not thread-safe, but the assertion is written incorrectly. The current setting does not terminate in a reasonable time using the standard search, and the program is poorly documented. Most documentation was given in PR #177 .
So I am not convinced that this example should be included in newer versions of JPF as of now.

@varad64
Copy link
Contributor Author

varad64 commented Aug 17, 2023

Thanks for the feedback, @cyrille-artho.
In that case, I will close this PR, as it does not offer any value in the current state.
Will reopen if the above stated concerns are resolved.

Thanks!

@varad64 varad64 closed this Aug 17, 2023
@cyrille-artho
Copy link
Member

cyrille-artho commented Aug 17, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants