Search for Xargo.toml in parent directories, including test #254
Conversation
|
The test "test" seems to be a bit unstable. It failed for me a couple of times as well, but now it works. |
|
That's a network failure indeed. I restarted that build. |
|
And now this fails due to rust-lang/rust#64320. We'll have to wait until that lands. |
|
All right, this should work now then. bors r+ |
254: Search for Xargo.toml in parent directories, including test r=RalfJung a=Nils-TUD So far, xargo expected the Xargo.toml in the directory of the Cargo.toml. This patch searches for the Xargo.toml by walking up the directory hierarchy. This is useful if a workspace is used, leading, for example, to one Cargo.toml with the workspace and multiple Cargo.toml files for the members of the workspace. With this patch, it is no longer necessary to have one Xargo.toml for each Cargo.toml, but only one next to the workspace, for example. Co-authored-by: Nils Asmussen <[email protected]>
Build failed |
|
Looks like your test does not work with the 2018-12-01 nightly? Is this a fairly recent target you are testing here? Could you use one used by other tests (and thus likely supported for longer already)? |
|
That's weird, because I did already copy the target from another test (and changed the middle part, as the other tests do, because apparently it's a problem if two have the same name). The Edit: And it's calling gcc, so that's too old apparently. But why isn't that called for the other test? |
|
I am not sure either. I don't know anything about all this ARM/cross-compilation stuff.^^ Maybe it has something to do with the "none" target also occurring here, whereas your target does not? |
|
Ok, it is interesting that the two other tests that have the comment "need this exact target name to get the right gcc flags" use an existing target (with "none"). So, maybe this is the problem. As far as I can see, it should be an existing target, but cannot be a target that the host has already built. Otherwise it will find the alloc library in any case. Let's try |
|
That does not seem to work...
Parallelism is another problem here -- tests are run in parallel. That's why the "host" tests have locking logic. |
|
What about modifying an existing test to have the toml file in a parent directory? |
But interestingly, my test (
That's exactly what I did, based on the I'm a bit lost here. It works for me locally and with travis, only other and unrelated tests fail. Any suggestions? |
Ah, I should have checked the log then. ;)
No, what I meant is not to copy and modify, but to modify in-place. |
|
Thanks a lot! bors r+ |
254: Search for Xargo.toml in parent directories, including test r=RalfJung a=Nils-TUD So far, xargo expected the Xargo.toml in the directory of the Cargo.toml. This patch searches for the Xargo.toml by walking up the directory hierarchy. This is useful if a workspace is used, leading, for example, to one Cargo.toml with the workspace and multiple Cargo.toml files for the members of the workspace. With this patch, it is no longer necessary to have one Xargo.toml for each Cargo.toml, but only one next to the workspace, for example. Co-authored-by: Nils Asmussen <[email protected]>
Build failed |
|
Why does it try to build the hm, maybe I should really just modify the |
|
I'm afraid I don't know. We could change the minimal supported version to |
|
I'm also fine with that, but I would suggest that I simply modify an existing test. I don't think that we lose anything with that. |
This commit does not add a new test, because a unique and existing target is required, which turned out to be challenging.
|
Yeah, this is fine. Thanks! bors r+ |
254: Search for Xargo.toml in parent directories, including test r=RalfJung a=Nils-TUD So far, xargo expected the Xargo.toml in the directory of the Cargo.toml. This patch searches for the Xargo.toml by walking up the directory hierarchy. This is useful if a workspace is used, leading, for example, to one Cargo.toml with the workspace and multiple Cargo.toml files for the members of the workspace. With this patch, it is no longer necessary to have one Xargo.toml for each Cargo.toml, but only one next to the workspace, for example. Co-authored-by: Nils Asmussen <[email protected]>
Build succeeded |
|
Yay, finally. :) |
|
Great :) |
So far, xargo expected the Xargo.toml in the directory of the Cargo.toml. This patch searches for the Xargo.toml by walking up the directory hierarchy. This is useful if a workspace is used, leading, for example, to one Cargo.toml with the workspace and multiple Cargo.toml files for the members of the workspace. With this patch, it is no longer necessary to have one Xargo.toml for each Cargo.toml, but only one next to the workspace, for example.