Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing #56

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Fix parsing #56

merged 1 commit into from
Jun 15, 2022

Conversation

thvdveld
Copy link
Contributor

This commit fixes some parsing errors I had.
Maybe this fixes #22, #28, #32 and #33.

Parsing is fixed for my own project, though I still have logged errors (at least the dot file is generated):

[2022-04-28T15:23:33Z ERROR cargo_call_stack] BUG? no callees for `void ({}*)`
[2022-04-28T15:23:33Z ERROR cargo_call_stack] BUG? no callees for `void ({}*, void ({}*)*)`

@gftea
Copy link

gftea commented Jun 13, 2022

the author seems no response? @thvdveld will you fork a new project and release another crate?

@thvdveld
Copy link
Contributor Author

@gftea indeed, however, @japaric seems to be working on other projects. So we should give him some time. In the meantime, you can just use my branch. I'm not really going to maintain it and release another crate.

However, I made some changes to the project, such as emitting a table in the terminal and allow the wrapper to catch builds from build.rs, which means catching stack sizes from C compilers when using -femit-stack-size. But I'm not sure if I'm doing this correctly. You can find my changes here: https://github.com/thvdveld/cargo-call-stack/tree/rewrite

But do not consider this rewrite to be a maintained fork 😉

@japaric thank you for creating this project! It helps me a lot in my research. Are you planning to maintain this?

@japaric
Copy link
Owner

japaric commented Jun 15, 2022

thanks for the ping! I missed the notification about this PR. also, thanks for the fix!

bors r+

bors bot added a commit that referenced this pull request Jun 15, 2022
56: Fix parsing r=japaric a=thvdveld

This commit fixes some parsing errors I had.
Maybe this fixes #22, #28, #32 and #33.

Parsing is fixed for my own project, though I still have logged errors (at least the dot file is generated):
```
[2022-04-28T15:23:33Z ERROR cargo_call_stack] BUG? no callees for `void ({}*)`
[2022-04-28T15:23:33Z ERROR cargo_call_stack] BUG? no callees for `void ({}*, void ({}*)*)`
```

Co-authored-by: Thibaut Vandervelden <[email protected]>
@japaric
Copy link
Owner

japaric commented Jun 15, 2022

CI passed but not sure why bors didn't automatically merged the PR. merging manually.

@japaric japaric merged commit 98501ef into japaric:main Jun 15, 2022
@japaric
Copy link
Owner

japaric commented Jun 15, 2022

release v0.1.7 includes this fix

@bors
Copy link
Contributor

bors bot commented Jun 15, 2022

Timed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to parse .ll file in v0.1.4
3 participants