Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Bump Qt6 from 6.6.3 to 6.7.3 (Automated PR) #3262

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Apr 6, 2024

This automated Pull Request updates the used Qt6 version to version 6.7.3.

This PR was opened by the workflow Bump dependencies (create-prs)

CHANGELOG: Build: Updated bundled Qt6 to version 6.7.3

@pljones pljones added this to the Release 3.12.0 milestone May 6, 2024
@pljones pljones added bug Something isn't working dependencies Pull requests that update a dependency file labels May 6, 2024
@pljones
Copy link
Collaborator

pljones commented May 6, 2024

#3282 raised to make it easier to see what needs looking at.

@pljones pljones removed the bug Something isn't working label May 6, 2024
@github-actions github-actions bot changed the title Build: Bump Qt6 from 6.6.3 to 6.7.0 (Automated PR) Build: Bump Qt6 from 6.6.3 to 6.7.1 (Automated PR) May 25, 2024
Copy link
Author

PR has been updated for version 6.7.1 by the workflow Bump dependencies (create-prs).

@hoffie hoffie force-pushed the ci/bump-dependencies/Qt6 branch 2 times, most recently from 3de866e to b973206 Compare May 25, 2024 21:54
@pljones
Copy link
Collaborator

pljones commented Jun 8, 2024

Is there a way to add some form of "back off" for want of a better term to bump-dependencies, so it's not so eager to take the very latest version? Maybe aiming for "LTS-1.patch" (long term support, version before latest LTS, but pick up latest patches for that as they may be security-related).

@softins
Copy link
Member

softins commented Jun 8, 2024

I guess that would just be a case of rewriting this appropriately:

latest_minor="$(curl -s https://download.qt.io/official_releases/qt/ | grep -oP 'href="\K[0-9.]+(?=/")' | sort --reverse --version-sort | head -n1)";

The trick would be in deciding what the rules should be for choosing a version.

@pljones
Copy link
Collaborator

pljones commented Jun 9, 2024

sort --version-sort | tail -n2 | head -n1 gets LTS-1 (and skips the unneeded reversal). Given asking for "6.7" gets us the updates from "6.7.0" to "6.7.1" here, I'd assume asking for "6.6" would keep us on latest patch to "6.6" until "6.8" (if that were an LTS) came out and then bump to latest "6.7", which is what I'd be expecting.

I don't see an easy way to get a list of tagged LTS versions... Maybe the source for Qt MaintenanceTool would reveal something.

@softins
Copy link
Member

softins commented Jun 10, 2024

I don't see an easy way to get a list of tagged LTS versions... Maybe the source for Qt MaintenanceTool would reveal something.

In the Qt Github repo, the string lts only appears in tags for 5.15.x and 6.2.x:

tony@pi:~/qt5 $ git tag -l '*lts*'
v5.15.10-lts-lgpl
v5.15.11-lts-lgpl
v5.15.12-lts-lgpl
v5.15.13-lts-lgpl
v5.15.14-lts-lgpl
v5.15.3-lts-lgpl
v5.15.4-lts-lgpl
v5.15.5-lts-lgpl
v5.15.6-lts-lgpl
v5.15.7-lts-lgpl
v5.15.8-lts-lgpl
v5.15.9-lts-lgpl
v6.2.5-lts-lgpl
v6.2.6-lts-lgpl
v6.2.7-lts-lgpl
v6.2.8-lts-lgpl
lines 1-16/16 (END)

So we will have to make our own project decisions. Your suggestion of tail and head would keep us on 6.6 until 6.8 comes out, and would then move us to 6.7, if that's your intention:

$ curl -s https://download.qt.io/official_releases/qt/ | grep -oP 'href="\K[0-9.]+(?=/")'
6.7
6.6
6.5
5.15

$ curl -s https://download.qt.io/official_releases/qt/ | grep -oP 'href="\K[0-9.]+(?=/")' | sort --reverse --version-sort | head -n1
6.7

$ curl -s https://download.qt.io/official_releases/qt/ | grep -oP 'href="\K[0-9.]+(?=/")' | sort --version-sort | tail -n2 | head -n1
6.6

@ann0see
Copy link
Member

ann0see commented Jun 20, 2024

So 6.5 is LTS (https://wiki.qt.io/Qt_version_history) but do we want to downgrade to that?

@pljones
Copy link
Collaborator

pljones commented Jun 21, 2024

So 6.5 is LTS (https://wiki.qt.io/Qt_version_history) but do we want to downgrade to that?

I don't think that can be relied on

The latest version of Qt is 6.5 released on 3 April 2023

and

Revision as of 14:15, 2 January 2024 by Liang Qi (talk | contribs) (Copied directly from https://web.archive.org/web/20231201152348/https://en.wikipedia.org/wiki/Wikipedia:Articles_for_deletion/Qt_version_history , the page was deleted in wikipedia)

It looks like someone copied it off a copy of a Wikipedia page and the original was deleted and it's not been updated (either before or) since in the Qt Wiki. The Wikipedia page would have been no more recent than 2023-12-01 (and possibly significantly older if it got locked when moved to Wikipedia:Articles_for_deletion).

@github-actions github-actions bot changed the title Build: Bump Qt6 from 6.6.3 to 6.7.1 (Automated PR) Build: Bump Qt6 from 6.6.3 to 6.7.2 (Automated PR) Jun 21, 2024
Copy link
Author

PR has been updated for version 6.7.2 by the workflow Bump dependencies (create-prs).

@hoffie hoffie force-pushed the ci/bump-dependencies/Qt6 branch 2 times, most recently from 7674a5a to 1b24103 Compare June 26, 2024 09:08
@hoffie hoffie force-pushed the ci/bump-dependencies/Qt6 branch 5 times, most recently from 969a8df to ef32ffa Compare July 2, 2024 19:53
@ann0see
Copy link
Member

ann0see commented Aug 23, 2024

@jamulussoftware/maindevelopers do we want the Qt version update in the next build or not?

@pljones
Copy link
Collaborator

pljones commented Aug 24, 2024

We're still investigating how to get the version we want, whether LTS or LTS-1 but not latest stable necessarily.

(I'm running 6.7.2 on all my Linux servers and my Windows client so I've no problem, as it happens.)

We also need a strategy to get off 5.x on all platforms.

@hoffie hoffie force-pushed the ci/bump-dependencies/Qt6 branch 3 times, most recently from 009e8dc to 81fe710 Compare August 26, 2024 17:12
@hoffie hoffie force-pushed the ci/bump-dependencies/Qt6 branch 5 times, most recently from bef8a41 to fc57554 Compare September 16, 2024 11:08
@hoffie hoffie force-pushed the ci/bump-dependencies/Qt6 branch 7 times, most recently from 5e3f431 to ddcbbe9 Compare September 22, 2024 16:43
@github-actions github-actions bot changed the title Build: Bump Qt6 from 6.6.3 to 6.7.2 (Automated PR) Build: Bump Qt6 from 6.6.3 to 6.7.3 (Automated PR) Sep 28, 2024
Copy link
Author

PR has been updated for version 6.7.3 by the workflow Bump dependencies (create-prs).

@hoffie hoffie force-pushed the ci/bump-dependencies/Qt6 branch 2 times, most recently from 283f3a8 to 2272961 Compare September 30, 2024 20:53
@pljones
Copy link
Collaborator

pljones commented Oct 1, 2024

I think we do this now and deal with the fall out?

Copy link
Member

@softins softins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think this would be a good moment, giving us plenty of time to address any issues.

@ann0see ann0see requested a review from pljones October 1, 2024 11:18
@pljones pljones merged commit 08b404c into main Oct 1, 2024
12 checks passed
@pljones pljones deleted the ci/bump-dependencies/Qt6 branch October 1, 2024 11:20
@pljones
Copy link
Collaborator

pljones commented Oct 1, 2024

Also updated all my (Ubuntu 24.04LTS) directories and servers to Qt 6.7.3. I briefly checked the Linux client UI and it looked okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants