Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link to weblate for app progress #3148

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Add link to weblate for app progress #3148

merged 1 commit into from
Sep 12, 2023

Conversation

pljones
Copy link
Collaborator

@pljones pljones commented Aug 19, 2023 •
edited
Loading

Short description of changes

Adds a link to weblate for app translation progress monitoring. This should appear, for example, as
Weblate progress

CHANGELOG: SKIP

Context: Fixes an issue?

Makes it easier to integrate Github and Weblate translation processes.

Does this change need documentation? What needs to be documented and how?

Maybe add a comment to Release Process.

Status of this Pull Request

Not tried it for real...

What is missing until this pull request can be merged?

It'll get used for 3.11.0 if merged...

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@pljones pljones added the tooling Changes to the automated build system label Aug 19, 2023
@pljones pljones added this to the Release 3.11.0 milestone Aug 19, 2023
@pljones pljones self-assigned this Aug 19, 2023
@ann0see
Copy link
Member

ann0see commented Sep 10, 2023

You could probably test it on your own repository. Not merging therefore. Otherwise it seems ok

@pljones
Copy link
Collaborator Author

pljones commented Sep 11, 2023

You could probably test it on your own repository. Not merging therefore. Otherwise it seems ok

Mmm, I'll try... Now's a good time anyway, as the release is out of the way.

@pljones
Copy link
Collaborator Author

pljones commented Sep 11, 2023

It needs a milestone set on my repo... possibly a project board... Let's see.

@pljones
Copy link
Collaborator Author

pljones commented Sep 11, 2023

Hm. OK, so to create the milestone, I opened a PR from my new pljones/jamulus/weblate-app-progress to pljones/jamulus/main and set the milestone to 'Release 3.10.1': pljones#20

Then I ran the script:

$ bash -eu tools/create-translation-issues.sh 3.10.1 2100-01-01 app '*TEST* Please ignore'
Creating app translation issues
Creating Issue to translate de_DE for 3.10.1
could not add to milestone 'Release 3.10.1': 'Release 3.10.1' not found

OK... so GH_REPO seems to be checked with a default of jamulussoftware/jamulus... I'll try again...

@pljones
Copy link
Collaborator Author

pljones commented Sep 11, 2023

That then gives

Creating app translation issues
the 'pljones/jamulus' repository has disabled issues

So I have to enable issues, too.

@pljones
Copy link
Collaborator Author

pljones commented Sep 11, 2023

It's a frustrating tool to test:

could not add label: 'translation' not found

It's meant to be creating translation issues - why can't it handle creating the label?

@pljones
Copy link
Collaborator Author

pljones commented Sep 11, 2023 •
edited
Loading

Well, this is more understandable:

could not add to project: 'Tracking' not found

I wonder where it's looking for the project.

PROJECT=Tracking
...
        URL=$(gh issue create --title "$title" --label translation --project "$PROJECT" --body "$body" --assignee "$translators" --milestone "$MILESTONE")

So I need a project called "Tracking" somewhere...

@pljones
Copy link
Collaborator Author

pljones commented Sep 11, 2023 •
edited
Loading

Finally

$ (export GH_REPO=pljones/jamulus; bash -eu tools/create-translation-issues.sh 3.10.1 2100-01-01 app '*TEST* Please ignore')
Creating app translation issues
Creating Issue to translate de_DE for 3.10.1
Updating Issue to translate de_DE for 3.10.1
Creating Issue to translate es_ES for 3.10.1
Updating Issue to translate es_ES for 3.10.1
Creating Issue to translate fr_FR for 3.10.1
Updating Issue to translate fr_FR for 3.10.1
Creating Issue to translate it_IT for 3.10.1
Updating Issue to translate it_IT for 3.10.1
No translator for ko_KR, assigning pljones - please re-assign as necessary
Creating Issue to translate ko_KR for 3.10.1
Updating Issue to translate ko_KR for 3.10.1
No translator for nb_NO, assigning pljones - please re-assign as necessary
Creating Issue to translate nb_NO for 3.10.1
Updating Issue to translate nb_NO for 3.10.1
Creating Issue to translate nl_NL for 3.10.1
Updating Issue to translate nl_NL for 3.10.1
Creating Issue to translate pl_PL for 3.10.1
Updating Issue to translate pl_PL for 3.10.1
Creating Issue to translate pt_BR for 3.10.1
Updating Issue to translate pt_BR for 3.10.1
Creating Issue to translate pt_PT for 3.10.1
Updating Issue to translate pt_PT for 3.10.1
Creating Issue to translate sk_SK for 3.10.1
Updating Issue to translate sk_SK for 3.10.1
Creating Issue to translate sv_SE for 3.10.1
Updating Issue to translate sv_SE for 3.10.1
Creating Issue to translate zh_CN for 3.10.1
Updating Issue to translate zh_CN for 3.10.1

image
Plus at-mentions for all the translators still happened (I guess I should have removed them).

@pljones
Copy link
Collaborator Author

pljones commented Sep 11, 2023 •
edited
Loading

All issues above deleted, project deleted, issues and projects disabled again. Label and milestone deleted.

@pljones
Copy link
Collaborator Author

pljones commented Sep 11, 2023 •
edited
Loading

Example of link text added:

**[Weblate progress](https://hosted.weblate.org/changes/browse/jamulus/jamulus-app/de_DE/?start_date=)**

Which should look like

Weblate progress

@ann0see
Copy link
Member

ann0see commented Sep 11, 2023

Great. Thanks. I believe this is ok then?

@pljones
Copy link
Collaborator Author

pljones commented Sep 11, 2023

OK, I wasn't passing the START_DATE to envsubst correctly. Fixed.

**[Weblate progress](https://hosted.weblate.org/changes/browse/jamulus/jamulus-app/de_DE/?start_date=2023-09-11)**

Weblate progress

ann0see
ann0see approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. If you think it's ready, merge it please.

softins
softins approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@softins softins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

@pljones pljones merged commit 043c15f into main Sep 12, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@softins softins softins approved these changes

@ann0see ann0see ann0see approved these changes

Assignees

@pljones pljones

Labels
tooling Changes to the automated build system
Projects
Tracking
Status: Done
Milestone
Release 3.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pljones @ann0see @softins