-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fully incorporate id(this) into JDQL #599
base: main
Are you sure you want to change the base?
Conversation
* @return the entities with the given unique identifiers. | ||
*/ | ||
@Query("where id(this) in :ids order by id(this)") | ||
List<T> findByIdIn(@By(ID) List<K> ids); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why put this method back again?
We agree to remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, we decided to remove it because we didn't have a good way to express it in any of the available query facilities, not because we hated it and thought it was useless.
I think it's kinda, well, at least medium-useful. Not a critical thing to have, but not a wart either.
Co-authored-by: Nathan Rauh <[email protected]>
@gavinking could you rebase this one? |
I will, but we have not decided to do it yet. |
A proposal, in case we want this in 1.0.