Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(upload): add support on upload to topic #559

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

XMLHexagram
Copy link
Contributor

close #500

@XMLHexagram
Copy link
Contributor Author

XMLHexagram commented Mar 26, 2024

@iyear I add both --topic flag and --to flag.

In this PR, users can use tdl up -c @foo --topic xxx as a legacy but convenient way to upload file to topic.

Or users can use --to and expr, for example, tdl up --to '{ Peer: "@foo", Thread: xxx }' to get the same result.

I wonder if this is a good practice to have two way to get the same goal, or just marking -c as deprecated and only reserving--to is a better solution?

(In my option, it is better if tdl can provide both a convenient way and an advanced way.)

I will update docs after you decide which way is better.

Looking forward to your reply.

@XMLHexagram
Copy link
Contributor Author

todo: add --to - list all available fields.

@Abu3safeer
Copy link

Any updates regarding this?

@iyear iyear self-requested a review as a code owner June 19, 2024 16:32
@iyear iyear force-pushed the master branch 2 times, most recently from bb47963 to 983b909 Compare June 19, 2024 16:33
@Ender-Wang
Copy link

Updates? Recently I need to upload a lot of files to my personal group that has a few threads, found out tdl does not support it yet, this looks great.

@Bhavya031
Copy link

@XMLHexagram this works great thank you for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] Ability to Upload to a Group Topic
4 participants