Aryan contri3 #26488
Aryan contri3 #26488
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:
- docs: correct typo in README
- feat: implement dark mode"
- fix: correct remove button behavior
Linting Errors
- Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
- No subject found
ivy-leaves
added
Array API
| x = ivy.array([1, 2]) | ||
| y = [ivy.array([[5, 6]]), ivy.array([[7, 8]])] | ||
| ivy.vstack((x, y)) | ||
| ivy.vstack((x, y, x, y)) | ||
| """ |
There was a problem hiding this comment.
Hi @Aryan8912, I think this docstring edit and the edit in the rst file are not related to the PR. We generally want to keep each PR focused on a specific issue. Could you remove those?
| @@ -129,7 +152,7 @@ def gather( | |||
| batch_dims: int = 0, | |||
| out: Optional[JaxArray] = None, | |||
| ) -> JaxArray: | |||
| axis = axis % len(params.shape) | |||
| axis = get_positive_axis_for_gather(axis, params.ndim) | |||
| batch_dims = batch_dims % len(params.shape) | |||
There was a problem hiding this comment.
As was discussed on #26624, you will need to make the same change to all backends and also change the default value of the axis argument to 0.
| @@ -129,7 +152,7 @@ def gather( | |||
| batch_dims: int = 0, | |||
| out: Optional[JaxArray] = None, | |||
| ) -> JaxArray: | |||
| axis = axis % len(params.shape) | |||
| axis = get_positive_axis_for_gather(axis, params.ndim) | |||
| batch_dims = batch_dims % len(params.shape) | |||
| ivy.utils.assertions.check_gather_input_valid(params, indices, axis, batch_dims) | |||
There was a problem hiding this comment.
Also, please make sure to search for all the places that ivy.gather is being used in our codespace and change the axis value as needed.
What I mean is, if ivy.gather is being called using the current default axis value, you will need to set it to axis=-1 to make up for changing the default. I hope this makes sense!
|
Closing this due to inactivity for over 6 months after changes were requested. Please feel free to reopen if you would like to continue working on this. Thank you :) |
PR Description
Related Issue
Close #23044
Checklist
Socials