Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added normal random at paddle frontend #23005

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

zeus2x7
Copy link
Contributor

@zeus2x7 zeus2x7 commented Sep 4, 2023

close #22780
Sub-Task #15043

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Sep 4, 2023
@lucasalavapena
Copy link
Contributor

Thanks for making a separate PR! I assigned myself to this PR (I hope you do not mind, I was not sure if you have the ability to change the assignee actually). If case you missed it, do not forget to address the comments I made in #22940

@zeus2x7
Copy link
Contributor Author

zeus2x7 commented Sep 4, 2023

hi @lucasalavapena
thanks for assigning yourself to this PR.
I have made the changes as per your review, can you please review it again?

@lucasalavapena
Copy link
Contributor

Perfect @zeus2x7 ! LGTM!

@lucasalavapena lucasalavapena merged commit 6f788e8 into ivy-llc:main Sep 5, 2023
118 of 133 checks passed
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

normal
4 participants