Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cosine_similarity and test to paddlepaddle frontend #16042

Conversation

diksha-shrivastava13
Copy link
Contributor

Close #16039
A work in progress

@diksha-shrivastava13 diksha-shrivastava13 marked this pull request as ready for review May 30, 2023 05:54
@RickSanchezStoic
Copy link
Contributor

lgtm!

@RickSanchezStoic RickSanchezStoic merged commit 10cbf92 into ivy-llc:master May 30, 2023
from ivy.func_wrapper import with_unsupported_dtypes


@with_unsupported_dtypes({"2.0.1 and below": ("float16", "bfloat16")}, "torch")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @diksha-shrivastava13 @RickSanchezStoic , in this code block, "torch" is mentioned. Shouldn't it be "paddle" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should, actually. I had been closely following PyTorch's implementation. I will open a pull request to refactor the same with
@with_supported_dtypes({"2.4.2 and below": ("float32", "float64")}, "paddle"). Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cosine_similarity
3 participants