lint

italia · Jul 30, 2024 · 55e731c · 55e731c
1 parent c3f81e9
commit 55e731c
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 20 deletions.
diff --git a/assets/js/components/PubliccodeBadge.js b/assets/js/components/PubliccodeBadge.js
@@ -4,28 +4,31 @@ import PropTypes from 'prop-types';
 import { Spinner } from './Spinner';
 
 const stateClass = {
-  'loading': 'secondary',
-  'good': 'success',
-  'error': 'danger',
+  loading: 'secondary',
+  good: 'success',
+  error: 'danger',
 };
 
 export const PubliccodeBadge = React.memo(({ id }) => {
   const [publiccodeState, setPubliccodeState] = useState('loading');
+  const logUrl = `https://api.developers.italia.it/v1/software/${id}/logs`;
 
-  useEffect(async () => {
-    const res = await fetch(logUrl);
+  useEffect(() => {
+    async function fetchLogs() {
+      const res = await fetch(logUrl);
 
-    if (res.status >= 200 || res.status <= 299) {
-      const data = await res.json();
-      const good = data.data[0]?.message.includes('GOOD publiccode.yml');
+      if (res.status >= 200 || res.status <= 299) {
+        const data = await res.json();
+        const good = data.data[0]?.message.includes('GOOD publiccode.yml');
 
-      setPubliccodeState(good ? 'good' : 'error');
-    } else {
-      setPubliccodeState('error');
+        setPubliccodeState(good ? 'good' : 'error');
+      } else {
+        setPubliccodeState('error');
+      }
     }
-  }, [logUrl]);
 
-  const logUrl = `https://api.developers.italia.it/v1/software/${id}/logs`
+    fetchLogs();
+  }, [logUrl]);
 
   return (
     <>
@@ -41,6 +44,7 @@ export const PubliccodeBadge = React.memo(({ id }) => {
         href={logUrl}
         target="_blank"
         aria-label="Log results of the latest publiccode.yml crawling"
+        rel="noreferrer"
       >
         (log)
       </a>

diff --git a/assets/js/components/Spinner.js b/assets/js/components/Spinner.js
@@ -2,12 +2,15 @@ import React from 'react';
 
 import './Spinner.css';
 
-export const Spinner = React.memo(() => {
-  return (
-    <>
-      <div className="lds-ellipsis"><div></div><div></div><div></div><div></div></div>
-    </>
-  );
-});
+export const Spinner = React.memo(() => (
+  <>
+    <div className="lds-ellipsis">
+      <div></div>
+      <div></div>
+      <div></div>
+      <div></div>
+    </div>
+  </>
+));
 
 Spinner.displayName = 'Spinner';