Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Lighthouse warning when score decreases #1420

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bfabio
Copy link
Member

@bfabio bfabio commented Sep 23, 2024

See #851.

Copy link
Contributor

⚡ Lighthouse report for the home page 🏠

Category Score
🟠 Performance 62
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

See the full report...

Other pages

@bfabio
Copy link
Member Author

bfabio commented Sep 23, 2024

This was previously #1143.

Looks like I removed my branch back in June (my bad) and GitHub automatically closed the PR, but restoring it doesn't allow to reopen the old PR. It's exactly the same content of #1143 and note it only checks for the Accessibilty, Best practices and SEO scores, not Performance.

Having this would've automatically caught the decrease in #1415 (Best practices in /progetto got down to 92).

Anyway, @Fupete you didn't merge it in favor of #1416, I guess you noticed something was off. @Fupete is better than CI ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants