Add keepalives to waypoint HBONE endpoint to mimic ztunnel #50737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Leggett <[email protected]>
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
istio-policy-bot
added
area/ambient
bleggett
changed the title
istio-testing
added
the
size/S
howardjohn
approved these changes
Apr 29, 2024
howardjohn
added
the
cherrypick/release-1.22
Signed-off-by: Benjamin Leggett <[email protected]>
|
/test release-notes |
Signed-off-by: Benjamin Leggett <[email protected]>
|
In response to a cherrypick label: new pull request created: #50738 |
luksa
pushed a commit
to luksa/istio
that referenced
this pull request
Oct 14, 2024
* upstream/master: validation: block invalid maglev table sizes (istio#50750) xds server: move files (istio#50708) ambient: fix auto-allow waypoint (istio#50710) Add ProxyConfig to list of non-stable resources (istio#50741) release notes for 50195 (istio#50722) Add keepalives to waypoint HBONE endpoint to mimic ztunnel (istio#50737) basic istio ascii art (istio#50699) add new retryon condition in validation code (istio#50726) Bump unshare-go dependency (istio#50725) Fix setting the merged service to servicesByHostname (istio#50691)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
In istio/ztunnel#931 we added keepalives to the serverside of the HBONE tunnel to work around a hyper client bug: hyperium/hyper#3647
This just adds the same things to the waypoint, for the same reasons.
IMO keepalives are probably worth having even if the hyper client bug is fixed, as a safety valve to keep misbehaving clients (even if they are ours) from hanging connections.