Issue 262: Notify the virtual closing of tag #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix isaacs#262: Emit a boolean value to indicate if the onclosetag event was sent without the closing tag actually existing in the document. Also: - changed the event emitters function to take a variable arguments list
Also slightly modify the test function to allow var args events tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the onclosetag event emiter to also provide a boolean value, as to notify if the closing tag operation was "virtual" (that is, if the closing tag did not exist in the parsed content) or not.
A small set of tests is provided to test if everything is working.
This PR also includes a change on the test function to take in account events the var args modification and allow to optionally test additionnal/optional data provided by event emiter, like the virtual boolean value in this case.
All tests are passing with given modifications.