-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid removing from brand media relay and application server sets in use #2795
Open
danigargar
wants to merge
5
commits into
bleeding
Choose a base branch
from
PROVIDER-2067-avoid-removing-from-brand-sets-in-use
base: bleeding
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Avoid removing from brand media relay and application server sets in use #2795
danigargar
wants to merge
5
commits into
bleeding
from
PROVIDER-2067-avoid-removing-from-brand-sets-in-use
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danigargar
added
+enhancement
Enhancement
core
Core Libraries
ci-force-tests-back
Run all backend pipeline tests in this Pull Request
*tempest*
IvozProvider 4.x Tempest Release
labels
Oct 22, 2024
danigargar
changed the base branch from
bleeding
to
PROVIDER-2053-adds-schema-relations-between-entities
October 22, 2024 07:42
danigargar
force-pushed
the
PROVIDER-2067-avoid-removing-from-brand-sets-in-use
branch
from
October 22, 2024 07:43
aaa4a36
to
21d7c07
Compare
danigargar
force-pushed
the
PROVIDER-2053-adds-schema-relations-between-entities
branch
from
October 22, 2024 13:44
d21f6ab
to
8ee3cbd
Compare
danigargar
force-pushed
the
PROVIDER-2067-avoid-removing-from-brand-sets-in-use
branch
6 times, most recently
from
October 22, 2024 16:20
8c50290
to
3c1f115
Compare
ironArt3mis
requested changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review required
danigargar
force-pushed
the
PROVIDER-2053-adds-schema-relations-between-entities
branch
2 times, most recently
from
October 23, 2024 09:21
0ce89b8
to
5ec744e
Compare
rbatistadev
approved these changes
Oct 23, 2024
danigargar
force-pushed
the
PROVIDER-2067-avoid-removing-from-brand-sets-in-use
branch
from
October 23, 2024 09:34
3c1f115
to
baf00d6
Compare
Base automatically changed from
PROVIDER-2053-adds-schema-relations-between-entities
to
bleeding
October 23, 2024 10:27
danigargar
force-pushed
the
PROVIDER-2067-avoid-removing-from-brand-sets-in-use
branch
from
October 23, 2024 10:28
baf00d6
to
55b3bca
Compare
media relay sets from brand application server sets from brand
danigargar
force-pushed
the
PROVIDER-2067-avoid-removing-from-brand-sets-in-use
branch
from
October 23, 2024 13:35
55b3bca
to
5dab9e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci-force-tests-back
Run all backend pipeline tests in this Pull Request
core
Core Libraries
+enhancement
Enhancement
functional-review
*tempest*
IvozProvider 4.x Tempest Release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lifecycle services checking if a MediaRelaySet or ApplicationServerSet is in use by a brand before removing the relation.
Type Of Change
Checklist:
Description
Additional information