[#480] Remove Python2 compatibility from code base #640

d-w-moore · 2024-10-15T20:24:27Z

With this change, we remove all code meant explicitly to deal with the possibility of the PRC's running under Python 2. Especially the awkward (and sometimes voluminous) parts that interfere with a ready understanding of the code base as a whole.

trel · 2024-10-16T02:02:32Z

looking good so far. please assert here how testing goes.

irods/message/__init__.py

d-w-moore · 2024-10-16T16:17:03Z

looking good so far. please assert here how testing goes.

have already done some piecemeal testing with good results. will run a full test later.

korydraughn · 2024-10-16T17:34:59Z

Excellent! Keep pushing.

d-w-moore · 2024-10-17T15:28:15Z

There may still be a few points I haven't thought of, but presently the code is exclusively Python3-compatible (python2 -c"import irods" fails !!) and passes all tests in the suite.

d-w-moore · 2024-10-17T15:47:53Z

.... now with minimal squashing

korydraughn · 2024-10-17T19:25:07Z

Amazing work!

We'll start the review process.

korydraughn

Looks good to me.

Let's get another set of eyes on this before squashing/merging.

Good stuff!

irods/test/data_obj_test.py

korydraughn · 2024-10-17T19:42:15Z

There may still be a few points I haven't thought of, but presently the code is exclusively Python3-compatible (python2 -c"import irods" fails !!) and passes all tests in the suite.

How much does python2 -c"import irods" actually catch? Do you know?

I'm just curious.

rename message.property module to avoid naming conflict introduce attribute irods.message.property at module EOF. this avoids corrupting the @Property facility used earlier in the module source file, and prevents possibility of breaking changes.

All Python3 classes are of the so called new style, ie directly subclassing "object". Old-style classes are a Python2 relic.

…ctly

d-w-moore · 2024-10-17T23:23:31Z

There may still be a few points I haven't thought of, but presently the code is exclusively Python3-compatible (python2 -c"import irods" fails !!) and passes all tests in the suite.

How much does python2 -c"import irods" actually catch? Do you know?

I'm just curious.

Here's what happens if you try importing the PRC at tip of this branch currently:

Python 2.7.18 (default, Jan 31 2024, 16:23:13) 
[GCC 9.4.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import irods
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/daniel/ppy3/prc/irods/__init__.py", line 85, in <module>
    from . import client_configuration
  File "/home/daniel/ppy3/prc/irods/client_configuration/__init__.py", line 40
    class ConnectionsProperties(iRODSConfiguration, metaclass = iRODSConfigAliasMetaclass):
                                                              ^
SyntaxError: invalid syntax
>>> irods
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
NameError: name 'irods' is not defined
>>>

As a result of the errors evoked, not the irods namespace, nor module, nor any submodules will be imported (as you might well intuit by that last command). Which means all code in the PRC is unavailable to the interpreter under Python2

d-w-moore · 2024-10-17T23:26:56Z

Amazing work!

We'll start the review process.

Great!...
Btw, I didn't mean to put the" laugh" emoji there. Joy is more what I wanted to express.

trel · 2024-10-18T01:37:44Z

Can we... be kinder to anyone who might stumble into this by accident...

like...

import sys

if sys.version_info[0] < 3:
    raise RuntimeError("This library is only supported on Python 3 and above.")

But also check the minor version while we're there...

d-w-moore · 2024-10-18T02:03:26Z

Can we... be kinder to anyone who might stumble into this by accident...

like...
import sys

if sys.version_info[0] < 3:
    raise RuntimeError("This library is only supported on Python 3 and above.")
But also check the minor version while we're there...

Good point. We'll put that into irods/__init__.py . It will work fine even if sub-namespaces are (naively) preferentially imported, because in order to import those, Python needs to import the parent modules first. (In other words, import irods.manager.data_object_manager has to import irods as the first step.

trel · 2024-10-18T02:09:02Z

nice and clean.

trel · 2024-10-18T02:24:51Z

irods/__init__.py

@@ -1,3 +1,8 @@
+import sys
+if sys.version_info[0] < 3:


let's also check minor version... aka that we're 3.8+.

Have we settled on 3.8 as a minimum, then? Sounds good to me.

Doesn’t have to be 3.8. But that feels about right for a new floor. Discush.

FifthPotato

Seems pretty complete to me. Couldn't find anything wrong, so I think it looks good!

alanking · 2024-10-18T14:03:58Z

setup.py

@@ -43,7 +43,6 @@
      packages=find_packages(),
      include_package_data=True,
      install_requires=[
-                        'six>=1.10.0',
                        'PrettyTable>=0.7.2',
                        'defusedxml',
                        # - the new syntax:


The lines following this one read...

# - the new syntax: #'futures; python_version == "2.7"' ], # - the old syntax: extras_require={ ':python_version == "2.7"': ['futures'], 'tests': ['unittest-xml-reporting'] # for xmlrunner }

Can we remove all of this now?

[_480] Py3: remove unneeded __future__ imports

8627c41

d-w-moore marked this pull request as draft October 15, 2024 20:24

trel reviewed Oct 16, 2024

View reviewed changes

irods/message/__init__.py Outdated Show resolved Hide resolved

d-w-moore force-pushed the 480.m branch 3 times, most recently from 41b4824 to 6b0d13d Compare October 16, 2024 14:33

d-w-moore self-assigned this Oct 16, 2024

d-w-moore force-pushed the 480.m branch from 704fce4 to 652c4b8 Compare October 16, 2024 16:21

[_480] Py3: unicode strings are implied

697d8b1

d-w-moore force-pushed the 480.m branch 2 times, most recently from d478f99 to fac1329 Compare October 17, 2024 14:12

d-w-moore marked this pull request as ready for review October 17, 2024 15:24

d-w-moore force-pushed the 480.m branch from 9bd92ea to efe4c2a Compare October 17, 2024 15:46

korydraughn reviewed Oct 17, 2024

View reviewed changes

irods/test/data_obj_test.py Show resolved Hide resolved

korydraughn requested a review from FifthPotato October 17, 2024 19:41

d-w-moore added 5 commits October 17, 2024 17:18

[_480] remove six module

3a2e6f3

rename message.property module to avoid naming conflict introduce attribute irods.message.property at module EOF. this avoids corrupting the @Property facility used earlier in the module source file, and prevents possibility of breaking changes.

[_480] Py3: remove redundant "object" in base class specifications

e2d3823

All Python3 classes are of the so called new style, ie directly subclassing "object". Old-style classes are a Python2 relic.

[_480] use format-strings where possible

ed29894

remove test helper In_Memory_Stream, construct file-like objects dire…

ea9fc7c

…ctly

display Collection name as unicode

cd7133b

d-w-moore force-pushed the 480.m branch from efe4c2a to cd7133b Compare October 17, 2024 21:20

whitespace: remove some non-initial tabs

fd6ab13

Check version before allowing import irods[.*[...]] to proceed

8eaff4b

trel reviewed Oct 18, 2024

View reviewed changes

change Python compatibility lower limit to 3.6

6ca3815

FifthPotato approved these changes Oct 18, 2024

View reviewed changes

alanking reviewed Oct 18, 2024

View reviewed changes

[_480] updates to setup.py for a Python3-only PRC

e8ed7f7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#480] Remove Python2 compatibility from code base #640

[#480] Remove Python2 compatibility from code base #640

d-w-moore commented Oct 15, 2024

trel commented Oct 16, 2024

d-w-moore commented Oct 16, 2024

korydraughn commented Oct 16, 2024

d-w-moore commented Oct 17, 2024

d-w-moore commented Oct 17, 2024

korydraughn commented Oct 17, 2024

korydraughn left a comment

korydraughn commented Oct 17, 2024

d-w-moore commented Oct 17, 2024 •

edited

Loading

d-w-moore commented Oct 17, 2024 •

edited

Loading

trel commented Oct 18, 2024 •

edited

Loading

d-w-moore commented Oct 18, 2024 •

edited

Loading

trel commented Oct 18, 2024

trel Oct 18, 2024

d-w-moore Oct 18, 2024

trel Oct 18, 2024

FifthPotato left a comment

alanking Oct 18, 2024

[#480] Remove Python2 compatibility from code base #640

Are you sure you want to change the base?

[#480] Remove Python2 compatibility from code base #640

Conversation

d-w-moore commented Oct 15, 2024

trel commented Oct 16, 2024

d-w-moore commented Oct 16, 2024

korydraughn commented Oct 16, 2024

d-w-moore commented Oct 17, 2024

d-w-moore commented Oct 17, 2024

korydraughn commented Oct 17, 2024

korydraughn left a comment

Choose a reason for hiding this comment

korydraughn commented Oct 17, 2024

d-w-moore commented Oct 17, 2024 • edited Loading

d-w-moore commented Oct 17, 2024 • edited Loading

trel commented Oct 18, 2024 • edited Loading

d-w-moore commented Oct 18, 2024 • edited Loading

trel commented Oct 18, 2024

trel Oct 18, 2024

Choose a reason for hiding this comment

d-w-moore Oct 18, 2024

Choose a reason for hiding this comment

trel Oct 18, 2024

Choose a reason for hiding this comment

FifthPotato left a comment

Choose a reason for hiding this comment

alanking Oct 18, 2024

Choose a reason for hiding this comment

d-w-moore commented Oct 17, 2024 •

edited

Loading

d-w-moore commented Oct 17, 2024 •

edited

Loading

trel commented Oct 18, 2024 •

edited

Loading

d-w-moore commented Oct 18, 2024 •

edited

Loading