Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate module support lists from device features (implements #689) #853

Merged
merged 6 commits into from
Jul 4, 2023

Conversation

ipspace
Copy link
Owner

@ipspace ipspace commented Jul 4, 2023

No description provided.

@ipspace ipspace merged commit bf78566 into dev Jul 4, 2023
8 checks passed
@ipspace ipspace deleted the sup_on branch July 4, 2023 10:01
@jbemmel
Copy link
Collaborator

jbemmel commented Jul 4, 2023

Would suggest to leave devices removed from the "supported_on" list in a comment, during the transition.
An unaware reader of the code now might think that a given feature is not supported on (say) eos

@ipspace
Copy link
Owner Author

ipspace commented Jul 4, 2023

Fair point. Added in 419b2fe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants