Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dhcp.client link attribute to enable DHCP on all non-relay nodes #1357

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

ipspace
Copy link
Owner

@ipspace ipspace commented Oct 10, 2024

Addresses the configuration part of #1343. The DHCP pools for the VLAN segments are not correct (duplicate pools, missing 'excluded' list)

…odes

Addresses the configuration part of #1343. The DHCP pools for the
VLAN segments are not correct (duplicate pools, missing 'excluded'
list)
@ipspace ipspace requested a review from jbemmel October 10, 2024 15:29
@ipspace
Copy link
Owner Author

ipspace commented Oct 10, 2024

See #1358 for more details on the DHCP pools issue

Copy link
Collaborator

@jbemmel jbemmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, no show stoppers

@ipspace ipspace merged commit cf0c7a8 into dev Oct 11, 2024
10 checks passed
@ipspace ipspace deleted the dhcp_client branch October 11, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants