lag based on link groups #1350
Draft
lag based on link groups #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbemmel
commented
Oct 10, 2024
jbemmel
force-pushed
the
linkgroup-lags
branch
from
677c103
to
d38cc9c
Compare
… instead of reverse engineering through _linkname
Cleanup _link_group attribute
|
You keep adding stuff, so I put the PR back into draft. Please let me know when you're done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A variation on the earlier PR:
This takes advantage of link groups, adding a simple
type: lagflag to convert them into link aggregation groups.After data model expansion for the link groups, the lag module uses the internal
_link_groupattribute to build aggregate links.Replaces #1337