Unify /etc/hosts file handling across CL,FRR and Linux VMs and containers #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ners The hosts file handling is done exclusively in the 'linux/hosts.j2' template with the contents being generated in the 'linux/hosts-common.j2' template. These templates are used in CL, FRR, and Linux initial configuration templates as well as (using symlinks) in the hosts.j2 templates used to generate clab_files that are mapped into the container /etc/hosts files. The content-generation template has been rewritten from scratch (the previous one generated invalid file format) and can be controlled with the 'netlab_intf_hosts' variable to generate hostnames that include interface names.
…e names If we define multiple IP address for a hostname in /etc/hosts, Linux picks a random IP address (not necessarily the first one) when doing ping or traceroute. To ensure the CLI commands always use the loopback IP address, we have to include interface names in IP addresses. Also, for hosts, the hostname has to be before the interface/hostname to get the correct name during the reverse IP lookup.
ssasso
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hosts file handling is done exclusively in the 'linux/hosts.j2' template with the contents being generated in the 'linux/hosts-common.j2' template.
These templates are used in CL, FRR, and Linux initial configuration templates as well as (using symlinks) in the hosts.j2 templates used to generate clab_files that are mapped into the container /etc/hosts files.
The content-generation template has been rewritten from scratch (the previous one generated invalid file format) and can be controlled with the 'netlab_intf_hosts' variable to generate hostnames that include interface names.