SR Linux: Routing policies cannot be used on route imports

ipspace · Sep 12, 2024 · f084d8b · f084d8b
1 parent bc78993
commit f084d8b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/netsim/devices/srlinux.yml b/netsim/devices/srlinux.yml
@@ -45,7 +45,7 @@ features:
     activate_af: True
     ipv6_lla: True
     rfc8950: True
-    import: [ ospf, isis, connected, vrf ]
+    import: [ ospf, isis, connected, vrf, no_policy ]
   evpn:
     irb: True
     asymmetrical_irb: True
@@ -60,7 +60,7 @@ features:
     ldp: True                           # on 7250 IXR only
   ospf:
     unnumbered: True
-    import: [ bgp, isis, connected, vrf ]
+    import: [ bgp, isis, connected, vrf, no_policy ]
     default: true
   routing:
     policy:

diff --git a/netsim/modules/_routing.py b/netsim/modules/_routing.py
@@ -509,7 +509,17 @@ def check_import_request(
       continue
 
     # Add an import routing policy if needed
-    node_add_routing_policy(i_dict.get(f'{s_proto}.policy'),node,topology)
+    i_policy = i_dict.get(f'{s_proto}.policy',None)
+    if i_policy:
+      if 'no_policy' in f_import:
+        log.error(
+          f'Device {node.device} (node {node.name}) cannot use routing policies ' + \
+          f'on route imports ({s_proto} => {proto}, policy {i_policy})',
+          category=log.IncorrectValue,
+          module=proto)
+        break
+      else:
+        node_add_routing_policy(i_dict.get(f'{s_proto}.policy'),node,topology)
 
   if 'ripv2' in i_dict:                                     # Finally, replace RIPv2 with RIP
     i_dict.rip = i_dict.ripv2