-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SD-JWT VC implementation #1413
Draft
UMR1352
wants to merge
22
commits into
main
Choose a base branch
from
feat/sd-jwt-vc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
SD-JWT VC implementation #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…solvers with the same signature
UMR1352
added
Enhancement
New feature or improvement to an existing feature
Added
A new feature that requires a minor release. Part of "Added" section in changelog
Rust
Related to the core Rust code. Becomes part of the Rust changelog.
labels
Sep 20, 2024
nanderstabel
reviewed
Oct 7, 2024
@@ -59,7 +71,14 @@ validator = ["dep:itertools", "dep:serde_repr", "credential", "presentation"] | |||
domain-linkage = ["validator"] | |||
domain-linkage-fetch = ["domain-linkage", "dep:reqwest", "dep:futures"] | |||
sd-jwt = ["credential", "validator", "dep:sd-jwt-payload"] | |||
jpt-bbs-plus = ["credential", "validator", "dep:zkryptium", "dep:bls12_381_plus", "dep:json-proof-token"] | |||
sd-jwt-vc = ["sd-jwt", "dep:sd-jwt-payload-rework", "dep:jsonschema"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature also seems to need "dep:futures"
, so:
sd-jwt-vc = ["sd-jwt", "dep:sd-jwt-payload-rework", "dep:jsonschema", "dep:futures"]
Without it downstream crates will encounter these compilation errors :) :
warning: `oid4vci` (lib) generated 2 warnings (run `cargo fix --lib -p oid4vci` to apply 2 suggestions)
error[E0433]: failed to resolve: use of undeclared crate or module `futures`
--> /home/nander/Impierce/identity.rs/identity_credential/src/sd_jwt_vc/metadata/vc_type.rs:1:5
|
1 | use futures::future::BoxFuture;
| ^^^^^^^ use of undeclared crate or module `futures`
error[E0433]: failed to resolve: use of undeclared crate or module `futures`
--> /home/nander/Impierce/identity.rs/identity_credential/src/sd_jwt_vc/metadata/vc_type.rs:2:5
|
2 | use futures::future::FutureExt;
| ^^^^^^^ use of undeclared crate or module `futures`
error[E0599]: no method named `boxed` found for `async` block `{async block@/home/nander/Impierce/identity.rs/identity_credential/src/sd_jwt_vc/metadata/vc_type.rs:105:3: 105:13}` in the current scope
--> /home/nander/Impierce/identity.rs/identity_credential/src/sd_jwt_vc/metadata/vc_type.rs:153:4
|
105 | / async move {
106 | | // Check if current type has already been checked.
107 | | let is_type_already_checked = passed_types.contains(¤t_type);
108 | | if is_type_already_checked {
... |
152 | | }
153 | | .boxed()
| | -^^^^^ method not found in `{async block@/home/nander/Impierce/identity.rs/identity_credential/src/sd_jwt_vc/metadata/vc_type.rs:105:3: 105:13}`
| |___|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Added
A new feature that requires a minor release. Part of "Added" section in changelog
Enhancement
New feature or improvement to an existing feature
Rust
Related to the core Rust code. Becomes part of the Rust changelog.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of SD-JWT VC draft 5.
Todo
identity_credential