Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SD-JWT VC implementation #1413

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

SD-JWT VC implementation #1413

wants to merge 22 commits into from

Conversation

UMR1352
Copy link
Contributor

@UMR1352 UMR1352 commented Sep 20, 2024

Implementation of SD-JWT VC draft 5.

Todo

  • Tests, tests, tests
  • Integration with credentials created through identity_credential
  • Verification & validation
  • Properly encode Rendering Metadata

@UMR1352 UMR1352 added Enhancement New feature or improvement to an existing feature Added A new feature that requires a minor release. Part of "Added" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Sep 20, 2024
@UMR1352 UMR1352 self-assigned this Sep 20, 2024
@@ -59,7 +71,14 @@ validator = ["dep:itertools", "dep:serde_repr", "credential", "presentation"]
domain-linkage = ["validator"]
domain-linkage-fetch = ["domain-linkage", "dep:reqwest", "dep:futures"]
sd-jwt = ["credential", "validator", "dep:sd-jwt-payload"]
jpt-bbs-plus = ["credential", "validator", "dep:zkryptium", "dep:bls12_381_plus", "dep:json-proof-token"]
sd-jwt-vc = ["sd-jwt", "dep:sd-jwt-payload-rework", "dep:jsonschema"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature also seems to need "dep:futures", so:

sd-jwt-vc = ["sd-jwt", "dep:sd-jwt-payload-rework", "dep:jsonschema", "dep:futures"]

Without it downstream crates will encounter these compilation errors :) :

warning: `oid4vci` (lib) generated 2 warnings (run `cargo fix --lib -p oid4vci` to apply 2 suggestions)
error[E0433]: failed to resolve: use of undeclared crate or module `futures`
 --> /home/nander/Impierce/identity.rs/identity_credential/src/sd_jwt_vc/metadata/vc_type.rs:1:5
  |
1 | use futures::future::BoxFuture;
  |     ^^^^^^^ use of undeclared crate or module `futures`

error[E0433]: failed to resolve: use of undeclared crate or module `futures`
 --> /home/nander/Impierce/identity.rs/identity_credential/src/sd_jwt_vc/metadata/vc_type.rs:2:5
  |
2 | use futures::future::FutureExt;
  |     ^^^^^^^ use of undeclared crate or module `futures`

error[E0599]: no method named `boxed` found for `async` block `{async block@/home/nander/Impierce/identity.rs/identity_credential/src/sd_jwt_vc/metadata/vc_type.rs:105:3: 105:13}` in the current scope
   --> /home/nander/Impierce/identity.rs/identity_credential/src/sd_jwt_vc/metadata/vc_type.rs:153:4
    |
105 | /   async move {
106 | |     // Check if current type has already been checked.
107 | |     let is_type_already_checked = passed_types.contains(&current_type);
108 | |     if is_type_already_checked {
...   |
152 | |   }
153 | |   .boxed()
    | |   -^^^^^ method not found in `{async block@/home/nander/Impierce/identity.rs/identity_credential/src/sd_jwt_vc/metadata/vc_type.rs:105:3: 105:13}`
    | |___|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added A new feature that requires a minor release. Part of "Added" section in changelog Enhancement New feature or improvement to an existing feature Rust Related to the core Rust code. Becomes part of the Rust changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants