-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce componentNameFormatter for react output target #235
base: main
Are you sure you want to change the base?
feat: introduce componentNameFormatter for react output target #235
Conversation
25d663b
to
7570e4d
Compare
HI @rwaskiewicz could I ping this for a review please? |
Hello @markhughes thanks for the PR! At this time we aren't prepared to review/merge this feature request, for a few reasons:
The next steps for this PR would be:
I realize this may not be ideal to the problems you are trying to solve and may also not align with your timeline. If that is the case, I would encourage you to use a forked version of this repository in the interim, so that you are able to solve your challenges. I would also encourage you to avoid directly pinging team members. While some individuals may appreciate the reminder, others may also find it to be interrupting or distracting. As a best practice, I tend not to tag individuals unless they are already involved in the conversation and I am replying to them. Let me know if you have any questions or need guidance on how to use a forked version. |
Hi @sean-perkins thanks for the response.
Moving on,
This has already been reported over a year ago. I referenced the ticket (#122) in my original opening message. I was planning on attending a bunch of simple issues neglected in this project.
I am just trying to un-neglect this projects issues.
This projects issues and PR's are heavily neglected, some are up to years of people trying to get help or fix issues, and I could only see you as the most recent contributor. I apologise that ended up you being pinged but I was literally told to ping a dev based on the previous response time (which is usually never) in this project. With this in mind I now have two concerns moving forward:
|
@markhughes thanks for your thoughts and feedback! I agree completely to the convention of tag names within React. The advantage of allowing selectors and component classes names in Stencil to be formatted from the compiler before output targets, is that the output targets responsibility simply becomes formatting I also agree that attention and maintenance on this project as a whole has been unclear and inconsistent. The purpose of many of the output targets has historically been focused on the needs of the Ionic Framework project. Realizing that the output targets were beneficial to the whole Stencil community, they were open sourced so that others may use them, without an alignment or plan on maintenance and further development. The team has started to work on that alignment and plan. Both the Framework dev team and the Stencil dev team now co-owns this repository. Stencil team's focus is on maintaining the compiler functionality against how the output targets are consumed and the Framework team is focused on the features actively used inside of Ionic Framework. I additionally have taken the responsibility of both triaging new issues (working on getting to existing issues) and backfilling process around: codeowners, contributing guidelines, Github actions for PR builds and release management, etc. It will take some time to bring this project up to speed and conventions. This project also requires a huge lift in terms of documentation and examples. If we can collaborate at the Github Issue level first, I'd be welcoming to contributions after we align on approach/scope. The unfortunate side effect at going PR first outside of a proof of concept, is that it already commits your time without certainty that the work will be proceeded with. I personally do not have issues with being pinged, as long as the expectation is not always an immediate response. I was just relaying feedback I have received in the past with different team members and trying to be respectful to their existing commitments. Addressing your concerns, here are my thoughts:
I believe next steps from this lengthy thread is:
I will take care of 1 and 3 on Monday. I hope you have a good weekend! |
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
Other (please describe):
What is the current behavior?
N/A
What is the new behavior?
This feature introduces a config option for the react output target called
componentNameFormatter
which allows formatting the name of component names generated in react.This is a very useful utility when you don't always want your name for your react package. For example, you may not want your react components to include the prefix, or you may want to add a prefix or suffix.
I have included an example in the
README.md
file.Also resolves #122
Does this introduce a breaking change?