chore: revert icons lifecycle fix

[liamdebeasi]

This reverts commit 7f7f346. As part of FW-5145 it was determined that this fix did not directly contribute to the resolution of the bug reported in #1278.

There is a chance that there is a behavior that still reproduces the reported issue that we are missing. However, I would rather have something break so we can a) root-cause the problem and b) add test coverage instead of have some code in the codebase indefinitely where people aren't really sure why it's needed.

Ionicons Dev build: 7.2.2-dev.11700519177.13b28f3a
Ionic Framework dev build with Ionicons dev build: 7.5.6-dev.11700519388.1583475f

You can test the dev build with the sidemenu starter app. I've also included a version of Ionic Framework that uses this dev build.

[thetaPC]

I'm still seeing blank icons with the dev builds that are listed in the description. What am I missing?

Ionic:

   Ionic CLI                     : 7.1.1 (/Users/maria/.nvm/versions/node/v18.16.0/lib/node_modules/@ionic/cli)
   Ionic Framework               : @ionic/angular 7.5.6-dev.11700519388.1583475f
   @angular-devkit/build-angular : 17.0.3
   @angular-devkit/schematics    : 17.0.3
   @angular/cli                  : 17.0.3
   @ionic/angular-toolkit        : 9.0.0

Capacitor:

   Capacitor CLI      : 5.5.1
   @capacitor/android : not installed
   @capacitor/core    : 5.5.1
   @capacitor/ios     : not installed

Utility:

   cordova-res                          : not installed globally
   native-run (update available: 2.0.0) : 1.7.4

System:

   NodeJS : v18.16.0 (/Users/maria/.nvm/versions/node/v18.16.0/bin/node)
   npm    : 9.5.1
   OS     : macOS Unknown

Here are my dependencies:

"dependencies": {
    "@angular/animations": "^17.0.2",
    "@angular/common": "^17.0.2",
    "@angular/compiler": "^17.0.2",
    "@angular/core": "^17.0.2",
    "@angular/forms": "^17.0.2",
    "@angular/platform-browser": "^17.0.2",
    "@angular/platform-browser-dynamic": "^17.0.2",
    "@angular/router": "^17.0.2",
    "@capacitor/app": "5.0.6",
    "@capacitor/core": "5.5.1",
    "@capacitor/haptics": "5.0.6",
    "@capacitor/keyboard": "5.0.6",
    "@capacitor/status-bar": "5.0.6",
    "@ionic/angular": "7.5.6-dev.11700519388.1583475f",
    "ionicons": "7.2.2-dev.11700519177.13b28f3a",
    "rxjs": "~7.8.0",
    "tslib": "^2.3.0",
    "zone.js": "~0.14.2"
  },

[liamdebeasi]

This isn't ready for review which is why it's still marked as a draft. I'm seeing the icons not loading with this PR, but I am seeing the icons loading if I create a dev build before the patch that this PR is trying to revert. I haven't had a chance to dig into it more.

edit: looks like github requests reviews from reviewers that I've manually added even if the PR is still a draft. I'll keep that in mind for next time.

[thetaPC]

@liamdebeasi should the branch be deleted as part of cleanup?