fix(): types generation

ionic-team · Jun 19, 2019 · ced468a · ced468a
1 parent 354195d
commit ced468a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/scripts/data.js b/scripts/data.js
@@ -159,7 +159,7 @@ sortedKeys.forEach(key => {
     const cjs = `exports.${d.exportCommonName} = {`;
     cjsOutput.push(cjs);
 
-    const dts = `export declare const ${d.exportCommonName} = {`;
+    const dts = `export declare const ${d.exportCommonName}: {`;
     dtsOutput.push(dts);
 
     for (let i = 0; i < modes.length; i++) {
@@ -168,7 +168,7 @@ sortedKeys.forEach(key => {
 
       esmOutput.push(`  ${mode}: ${d.modes[mode].modeImportName}${suffix}`);
       cjsOutput.push(`  ${mode}: ${d.modes[mode].modeImportName}${suffix}`);
-      dtsOutput.push(`  ${mode}: string${suffix}`);
+      dtsOutput.push(`  ${mode}: string;`);
     }
 
     esmOutput.push(`};`);

diff --git a/src/components/components.d.ts b/src/components/components.d.ts
@@ -25,7 +25,7 @@ export namespace Components {
     /**
     * A combination of both `name` and `src`. If a `src` url is detected it will set the `src` property. Otherwise it assumes it's a built-in named SVG and set the `name` property.
     */
-    'icon'?: string;
+    'icon'?: any;
     /**
     * Specifies which icon to use on `ios` mode.
     */
@@ -87,7 +87,7 @@ declare namespace LocalJSX {
     /**
     * A combination of both `name` and `src`. If a `src` url is detected it will set the `src` property. Otherwise it assumes it's a built-in named SVG and set the `name` property.
     */
-    'icon'?: string;
+    'icon'?: any;
     /**
     * Specifies which icon to use on `ios` mode.
     */

diff --git a/src/components/icon/readme.md b/src/components/icon/readme.md
@@ -12,7 +12,7 @@
 | `ariaLabel` | `aria-label` | Specifies the label to use for accessibility. Defaults to the icon name.                                                                                                       | `string \| undefined`  | `undefined` |
 | `color`     | `color`      | The color to use for the background of the item.                                                                                                                               | `string \| undefined`  | `undefined` |
 | `flipRtl`   | `flip-rtl`   | Specifies whether the icon should horizontally flip when `dir` is `"rtl"`.                                                                                                     | `boolean \| undefined` | `undefined` |
-| `icon`      | `icon`       | A combination of both `name` and `src`. If a `src` url is detected it will set the `src` property. Otherwise it assumes it's a built-in named SVG and set the `name` property. | `string \| undefined`  | `undefined` |
+| `icon`      | `icon`       | A combination of both `name` and `src`. If a `src` url is detected it will set the `src` property. Otherwise it assumes it's a built-in named SVG and set the `name` property. | `any`                  | `undefined` |
 | `ios`       | `ios`        | Specifies which icon to use on `ios` mode.                                                                                                                                     | `string \| undefined`  | `undefined` |
 | `lazy`      | `lazy`       | If enabled, ion-icon will be loaded lazily when it's visible in the viewport. Default, `false`.                                                                                | `boolean`              | `false`     |
 | `md`        | `md`         | Specifies which icon to use on `md` mode.                                                                                                                                      | `string \| undefined`  | `undefined` |