-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ios)!: Bump minimum deployment target to 14.0 #7679
Conversation
@@ -1116,7 +1118,7 @@ | |||
ENABLE_USER_SCRIPT_SANDBOXING = YES; | |||
GCC_C_LANGUAGE_STANDARD = gnu17; | |||
GENERATE_INFOPLIST_FILE = YES; | |||
IPHONEOS_DEPLOYMENT_TARGET = 17.0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, was there a specific reason this was previously set to 17.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's from a "CodableTests" subproject, probably when created, Xcode set the version to 17 as the default and was not changed. Doesn't really affect the project or the users, but changed it for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some of the CLI tests are failing for iOS. Seems to be related to the test project its using having a version lower than the new deployment target set.
Yeah, I'm updating the deployment target for the CLI and once that's merged should fix this |
Bump the minimum deployment target to 14 for podspec files, native projecs and tests projects (for some of them I had to downgrade)
Remove code that becomes irrelevant after the bump.