fix(cli): replace app-store deprecated method on build #7637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested review from
IT-MikeS,
andredestro,
markemer,
EiyuuZack,
Chuckytuh,
theproducer and
usernuno
andredestro
approved these changes
Sep 2, 2024
theproducer
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
app-storeis deprecated and was replaced withapp-store-connectin Xcode 14.3.It doesn't cause build failures yet, but better replace it now before it causes issues or breaks builds in the future.
It won't be cherry picked into 5.x branch since Capacitor 5 supports Xcode 14 and would require additional logic to use one value or the other based on the Xcode version.
closes #7632