chore(ios)!: Bump minimum deployment target to 14.0 #7679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested review from
Steven0351,
andredestro,
markemer,
EiyuuZack,
Chuckytuh,
theproducer,
usernuno and
eric-horodyski
| @@ -1116,7 +1118,7 @@ | |||
| ENABLE_USER_SCRIPT_SANDBOXING = YES; | |||
| GCC_C_LANGUAGE_STANDARD = gnu17; | |||
| GENERATE_INFOPLIST_FILE = YES; | |||
| IPHONEOS_DEPLOYMENT_TARGET = 17.0; | |||
There was a problem hiding this comment.
Just curious, was there a specific reason this was previously set to 17.0?
There was a problem hiding this comment.
It's from a "CodableTests" subproject, probably when created, Xcode set the version to 17 as the default and was not changed. Doesn't really affect the project or the users, but changed it for consistency.
eric-horodyski
approved these changes
Sep 26, 2024
theproducer
requested changes
Sep 26, 2024
|
Yeah, I'm updating the deployment target for the CLI and once that's merged should fix this |
theproducer
approved these changes
Sep 26, 2024
Steven0351
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the minimum deployment target to 14 for podspec files, native projecs and tests projects (for some of them I had to downgrade)
Remove code that becomes irrelevant after the bump.