Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync jparse one more time before freeze #1001

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Conversation

xexyl
Copy link
Contributor

@xexyl xexyl commented Oct 10, 2024

Synced jparse from jparse repo (https://github.com/xexyl/jparse/). This includes better (additional) testing of JSON encoding/decoding ('Beware of the dragon fire drake[0]
(https://www.glyphweb.com/arda/f/firedrakes.html)!' :-) ), a new version string (UTF-8 version, which is now also displayed in the tools in this repo, as it also helps identify if there is a mismatch in versions in bug reporting or something else), amongst various other things. Should one wish to further progress their dementia! :-) they can look at that repo's log or the jparse/CHANGES.md file.

[0] Now given that it's for a code freeze, the question is why not cold drakes? Well one can look at the code, or perhaps the output of a certain option to two tools in jparse, for the answer to that! :-)

Synced jparse from jparse repo (https://github.com/xexyl/jparse/). This
includes better (additional) testing of JSON encoding/decoding ('Beware
of the <del>dragon</del> fire drake[0]
(https://www.glyphweb.com/arda/f/firedrakes.html)!' :-) ), a new version
string (UTF-8 version, which is now also displayed in the tools in this
repo, as it also helps identify if there is a mismatch in versions in
bug reporting or something else), amongst various other things.  Should
one wish to further progress their dementia! :-) they can look at that
repo's log or the jparse/CHANGES.md file.

[0] Now given that it's for a code freeze, the question is why not cold
drakes? Well one can look at the code, or perhaps the output of a
certain option to two tools in jparse, for the answer to that! :-)
@xexyl
Copy link
Contributor Author

xexyl commented Oct 10, 2024

I hope you enjoy the commentary there as well as the branch name ... I know you will but I hope so anyway :-)

Copy link
Contributor

@lcn2 lcn2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here be dragons 🐉 ‼️

🤓

@lcn2 lcn2 merged commit 05fe708 into ioccc-src:master Oct 10, 2024
3 checks passed
@xexyl
Copy link
Contributor Author

xexyl commented Oct 10, 2024

Here be dragons 🐉 ‼️

Well here I'll do it... even though I probably shouldn't. I wanted to in jparse but this is probably even better, the way I did it:

🫃🔥🐉
🤰🔥🐉

Poor humans, they might say, but I think poor dragons: 'If room isn't found for them, they'll find it for themselves. They've a right to live, same as other folk.'

🤓

I almost used your wording instead but then I felt like, given the code, that was not the right wording. And the word exact words were not coming to my mind anyway and I was trying to hurry it up.

@xexyl xexyl deleted the fire-drakes branch October 10, 2024 18:07
@lcn2
Copy link
Contributor

lcn2 commented Oct 10, 2024

Here be dragons 🐉 ‼️

Well here I'll do it... even though I probably shouldn't. I wanted to in jparse but this is probably even better, the way I did it:

🫃🔥🐉 🤰🔥🐉

Poor humans, they might say, but I think poor dragons: 'If room isn't found for them, they'll find it for themselves. They've a right to live, same as other folk.'

🤓

I almost used your wording instead but then I felt like, given the code, that was not the right wording. And the word exact words were not coming to my mind anyway and I was trying to hurry it up.

We were mildly surprised to not find a plain ᐤ ring in the mix 🤓. Perhaps when issue 21 in the jparse repo is processed, the test could be LoTR Unicode enhanced?

@xexyl
Copy link
Contributor Author

xexyl commented Oct 10, 2024

Here be dragons 🐉 ‼️

Well here I'll do it... even though I probably shouldn't. I wanted to in jparse but this is probably even better, the way I did it:
🫃🔥🐉 🤰🔥🐉
Poor humans, they might say, but I think poor dragons: 'If room isn't found for them, they'll find it for themselves. They've a right to live, same as other folk.'

🤓

I almost used your wording instead but then I felt like, given the code, that was not the right wording. And the word exact words were not coming to my mind anyway and I was trying to hurry it up.

We were mildly surprised to not find a plain ᐤ ring in the mix 🤓. Perhaps when issue 21 in the jparse repo is processed, the test could be LoTR Unicode enhanced?

Which code point is that please? Would it be in place of the one I used (which is wrong technically)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants