Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Dark mode #198

Closed
wants to merge 21 commits into from
Closed

WIP: Dark mode #198

wants to merge 21 commits into from

Conversation

lkeude96
Copy link

Before you make a Pull Request, read the important guidelines:

Issue Link 🔗 #184

  • Is this a bug fix or a feature?
  • Feature
  • Does it break any existing functionality?
  • I think because we introduce some new properties to the theme protocol, it might cause some erroes

Goals of this PR 🎉

  • Why is the change important?
  • Its dark mode 😂
  • What does this fix?
  • How far has it been tested?

How Has This Been Tested 🔍

Please let us know if you have tested your PR and if we need to reproduce the issues. Also, please let us know if we need any relevant information for running the tests.

  • User Interface Testing
  • Application Testing

Test Configuration 👾

  • Xcode version: 11.1 (11A1027)
  • Device/Simulator: Simulator
  • iOS version: iOS 13.1

Things to check on 🎯

  • My Pull Request code follows the coding standards and styles of the project
  • I have worked on unit tests and reviewed my code to the best of my ability
  • I have used comments to make other coders understand my code better
  • My changes are good to go without any warnings
  • I have added unit tests both for the happy and sad path
  • All of my unit tests pass successfully before pushing the PR
  • I have made sure all dependent downstream changes impacted by my PR are working

@croossin
Copy link
Contributor

@lkeude96 Are the only issues the shadows?

@croossin
Copy link
Contributor

croossin commented Jan 7, 2020

Closing this and moving to PR #216 so that we can develop on CardPart branch instead of a fork.

@croossin croossin closed this Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants