iOS 13 Dark Mode?

[ghost]

Does this library support iOS 13's dark mode?

[croossin]

We have added no additional logic, color schemes, etc. to deal with iOS 13's dark mode. If you would like to take up the research and/or implementation on that, it would be greatly appreciated. We can add a Hacktoberfest label as well.

[lkeude96]

Hello @croossin. I will probably give it a shot :)

[croossin]

Love it ;) Will assign the issue to you!

@lkeude96 Would also be cool to try and remove any sort of Turbo or Mint references so that the framework can be as generic as possible

[lkeude96]

First Pass

👋 @croossin after looking at the codebase and the current available themes, I was thinking of potentially creating CardPartsSystemTheme and CardPartsCustomTheme (not sure if those would be the final names yet).

• CardPartsSystemTheme would utilize the new Dynamic and Semantic System colors. Also this new theme would be used as the new default theme for CardParts.theme.
• CardPartsCustomTheme would use the init(dynamicProvider:) initializer on UIColor with some of the original turbo color values. I'm not sure what would the adaptive color equivalents be but I could potentially come up a with a decent dark palette from them. CardPartsCustomTheme would mainly be used as an example to how to support dark mode.
• In addition, I would update the README's Themes and add a subsection explaining how to support dark mode for card part.

Questions:

• For the Turbo and Mint themes/references, Would be removing them entirely or just rename them?

Thank you, 😄

[croossin]

I like the idea of the system and custom themes..!

I'm thinking that we can remove them and just add any of the values we are using inside the themes as a generic color extension. I just want to make the project as generic as possible.

Thanks for all the input!

[lkeude96]

Work in progress.... (CardPartsSystemTheme) 😅

[lwdupont]

Woo sweet!!

[ghost]

@lkeude96 Thanks for looking into it. Looks great. Looking forward for the update soon!

[croossin]

This is awesome, @lkeude96 ! Great job. Keep us updated

[croossin]

@lkeude96 How's it coming along?

[lkeude96]

@croossin 👋 Hi sorry for the delay. it's coming along great. Took slightly longer than expected due to some additional workaround in order to maintain backward compatibility. I will be opening a WIP pr soon to start getting feedback and in order to discuss how we want to expose those API to someone using the library. 😄

[croossin]

Sounds good, @lkeude96 !

[lwdupont]

Can't wait! :)

[croossin]

@lkeude96 - how’s it coming along? Think we will be able to merge before end of month?

[lkeude96]

@croossin Just open a WIP PR. 😅One of the main, thing i was still trying to get to work are shadows 🤔

[croossin]

@lkeude96 Are shadows the only things missing from having dark mode support?

[Draelyre]

How do we make the background of the CardPartsViewController dark like in the image @lkeude96 sent?

[yohaoquan]

Hey guys. Any update on this? Or anyway I could change the background colour of the VC?