-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for cocos2d-x 4.0 and axmol #4
Open
crazyhappygame
wants to merge
17
commits into
intmainreturn00:master
Choose a base branch
from
crazyhappygame:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intmainreturn00
force-pushed
the
master
branch
from
September 3, 2024 21:13
82ddda6
to
982ed26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build for cocos2d-x-4.0 on M1 mac. ✅ (I needed to patch a few things in cocos itself in order to make it run in M1, but nothing graphics related)
- On top of the file:
USING_NS_CC;
→#define USING_NS_CC using namespace cocos2d
so, I should have access from this file without usingcocos2d::
prefix. - auto * works for me. Are there any problems with using auto? I thought even cocos2dx docs recommends using modern c++.
- In my 4.0 DrawNode I don't have
_bufferTriangle + _bufferCountTriangle
. axmol DrawNode is different? My local build also fails if I try to access_customCommandTriangle
for the same reason.
Need more info. 🙏 ping me if I can help somehow with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.