refactor: introduce ErrorWithKey (locales keys as error code)
#621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: background
Extension builds preview
|
){kind=icon}
){kind=icon}
sidvishnoi
force-pushed
the
error-with-key
branch
from
7742172
to
54b573b
Compare
sidvishnoi
changed the title
ErrorWithKey (translation keys as error code)ErrorWithKey (locales keys as error code)
fix: limit error codes to ErrorKey (instead of all TranslationKeys) nit: rename IErrorWithKey to ErrorWithKeyLike
sidvishnoi
force-pushed
the
error-with-key
branch
from
8f5f5d1
to
62d03f2
Compare
lengyel-arpad85
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes #620
Extracted from #619 (check out usage in
addPublicKeyToWallet+ its handler; also inConnectWalletFormvalidation handler)Changes proposed in this pull request
ErrorWithKey(extendsError; useful for throwing with stack-trace)errorWithKey(lighter version ofErrorWithKey; useful when stack-trace not needed)isErrorWithKey(checks if an object isErrorWithKeyor response oferrorWithKey)ErrorResponseandfailureto have optional{error?: ErrorWithKeyLike}t,useTranslation) to allow convertingErrorWithKeyLiketo string via_locales/[lang]/message.json