feat: use new UX flow for connecting wallet #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area: popup
Extension builds preview
|
){kind=icon}
){kind=icon}
github-actions
bot
added
the
area: background
remove ADD_PUBLIC_KEY_TO_WALLET messaging; can be added later if needed
This comment was marked as outdated.
This comment was marked as outdated.
fix: continue connect if key add succeeds code simplification, cleanup
sidvishnoi
force-pushed
the
setup-page/new-flow
branch
2 times, most recently
from
4d4b3b3
to
c29a7f7
Compare
remove unnecessary div more cleanup (try to reduce diff size) undo some of above cleanup attempts (no benefit of diff size)
sidvishnoi
force-pushed
the
setup-page/new-flow
branch
from
c29a7f7
to
ae77a5b
Compare
|
@sidvishnoi can we update the copy please and the layout (amount + renew) as provided on 565 . Thanks! |
sidvishnoi
force-pushed
the
setup-page/new-flow
branch
from
bf0cd44
to
8c6f887
Compare
(don't wait for blur)
This reverts commit 8774b2d.
sidvishnoi
commented
Sep 25, 2024
…tization-extension into setup-page/new-flow
|
Demo (final) (ignore 00:40 to 00:50 part; i had key already added, so it didn't' follow the path this PR adds support for - it went to connect consent directly) Screencast.from.25-09-24.05.45.59.PM.IST.webm |
lengyel-arpad85
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes proposed in this pull request
connectWalletto support automatic key addition to walletconnectWalletattempts won't try to add the key, until popup is closed._locales/en/messages.json.but with following difference from linked issue:It'll initially not disable the submit button (no input), but if user tries to submit, then it'll show errors inline and then disable the button until correct data is provided. This provides a better user experience, telling why user can't submit, instead of blanket button disable.Disables button on start as @RabebOthmani asked.ConnectWalletForm: Removereact-hook-formfromConnectWalletFormcomponent, as it was causing too many re-renders (and validation re-runs - like fetching wallet) when input changed (buggy library). It was re-rendering the entireConnectWalletFormcomponent, not just inputs.To reviewers:
Demo: #619 (comment)
src/_locales/en/messages.json