Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bg/openPayments): handle invalid_continuation on disconnect #609

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix(bg/openPayments): handle invalid_continuation on disconnect #609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/background/services/openPayments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,7 @@ export class OpenPaymentsService {
try {
await this.client!.grant.cancel(grantContinuation);
} catch (error) {
if (isInvalidClientError(error)) {
if (isInvalidClientError(error) || isInvalidContinuationError(error)) {
// key already removed from wallet
return;
}
Expand Down Expand Up @@ -787,6 +787,11 @@ export const isInvalidClientError = (error: any) => {
return error.status === 400 && error.code === 'invalid_client';
};

export const isInvalidContinuationError = (error: any) => {
if (!isOpenPaymentsClientError(error)) return false;
return error.status === 401 && error.code === 'invalid_continuation';
sidvishnoi marked this conversation as resolved.
Show resolved Hide resolved
};

// RESOURCE SERVER error. Create outgoing payment and create quote can fail
// with: `Signature validation error: could not find key in list of client keys`
export const isSignatureValidationError = (error: any) => {
Expand Down