Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use message.send() directly, move message to container #534

Merged
merged 14 commits into from
Aug 23, 2024
Merged

refactor: use message.send() directly, move message to container #534

merged 14 commits into from
Aug 23, 2024

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Aug 22, 2024 •
edited
Loading

Context

Closes #499

Changes proposed in this pull request

  • Move MessageManager instance into container/context so we don't have to import browser at top-level (makes browser easily replaceable for testing)
  • Reduce indirection when sending messages, and simplify call signature - aligning it more with how we use SendToPopup

sidvishnoi and others added 2 commits August 22, 2024 13:55
@sidvishnoi @raducristianpopa
refactor(content): move MessageManager to container
7dad49b 
Update MessageManager constructor to support awilix PROXY

Co-authored-by: Radu-Cristian Popa <[email protected]>
@sidvishnoi @raducristianpopa
use message.send directly everywhere
ce42400 
Co-authored-by: Radu-Cristian Popa <[email protected]>
@github-actions github-actions bot added area: content Improvements or additions to extension content script area: background Improvements or additions to extension background script area: popup Improvements or additions to extension popup labels Aug 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 22, 2024 •
edited
Loading

Extension builds preview

Name Link
Latest commit 75d3b5c
Latest job logs Run #10509734798
BadgeDownload
BadgeDownload

@sidvishnoi sidvishnoi changed the title Move message manger to container refactor: use message.send() directly, move MessageManager into container Aug 22, 2024
@sidvishnoi sidvishnoi changed the title refactor: use message.send() directly, move MessageManager into container refactor: use message.send() directly, move message to container Aug 22, 2024
raducristianpopa
raducristianpopa reviewed Aug 22, 2024
View reviewed changes
src/content/services/monetizationTagManager.ts Outdated Show resolved Hide resolved
src/popup/components/ErrorKeyRevoked.tsx Outdated Show resolved Hide resolved
src/popup/components/OutOfFunds.tsx Outdated Show resolved Hide resolved
@sidvishnoi sidvishnoi marked this pull request as ready for review August 22, 2024 14:09
@sidvishnoi sidvishnoi merged commit 0e8941b into main Aug 23, 2024
8 checks passed
@sidvishnoi sidvishnoi deleted the move-MessageManger-to-container branch August 23, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raducristianpopa raducristianpopa raducristianpopa approved these changes

Assignees
No one assigned
Labels
area: background Improvements or additions to extension background script area: content Improvements or additions to extension content script area: popup Improvements or additions to extension popup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move MessageManager in the container
2 participants
@sidvishnoi @raducristianpopa