feat(popup): add ouf of funds and add funds screens #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: popup
Extension builds preview
|
){kind=icon}
){kind=icon}
sidvishnoi
changed the title
sidvishnoi
commented
Jul 22, 2024
sidvishnoi
commented
Jul 22, 2024
Comment on lines
+15
to
+22
| if (location.pathname.includes('/s/')) { | ||
| return ( | ||
| <Link to={location.pathname.split('/s/')[0]}> | ||
| <ArrowBack className="h-6" /> | ||
| </Link> | ||
| ) | ||
| } | ||
|
|
There was a problem hiding this comment.
sidvishnoi
commented
Jul 22, 2024
|
Demo (to show what texts are shown where and the interactions) Screencast.from.22-07-24.08.05.45.PM.IST.webm |
sidvishnoi
commented
Jul 22, 2024
dianafulga
approved these changes
Jul 23, 2024
tselit
approved these changes
Jul 23, 2024
sidvishnoi
commented
Jul 23, 2024
sidvishnoi
commented
Jul 23, 2024
sidvishnoi
commented
Jul 23, 2024
Comment on lines
+53
to
+56
| { | ||
| path: ROUTES_PATH.OUT_OF_FUNDS_ADD_FUNDS, | ||
| lazy: () => import('./pages/OutOfFunds_AddFunds') | ||
| }, |
There was a problem hiding this comment.
Good approach. Let's avoid having other folders in pages. For the future, defining sub-routes should happen like this.
raducristianpopa
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes proposed in this pull request
/s/in URL (s for screen or sub-page). It allows going back to parent - path before/s/.