Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(background): resend last monetization event on reload when overpaying #423

Merged
merged 5 commits into from
Jul 15, 2024
Merged

feat(background): resend last monetization event on reload when overpaying #423

merged 5 commits into from
Jul 15, 2024

Conversation

raducristianpopa
Copy link
Member

@raducristianpopa raducristianpopa commented Jul 14, 2024 •
edited
Loading

Context

Closes #422.

Changes proposed in this pull request

  • Changed MonetizationEventPayload: detail -> details
  • Updated tabState methods to store the monetization event as well.
  • Session now sends the last monetization event when starting an overpaying payment session

@github-actions github-actions bot added area: content Improvements or additions to extension content script area: background Improvements or additions to extension background script labels Jul 14, 2024
@raducristianpopa
Copy link
Member Author

raducristianpopa commented Jul 14, 2024 •
edited
Loading

Extension builds preview

Name Link
Latest commit 65e4eb7
Latest job logs Run #9936908574
BadgeDownload
BadgeDownload

@raducristianpopa raducristianpopa changed the title Rp/422/overpaying event feat(background): store and send last monetization when starting an overpaying session Jul 14, 2024
@raducristianpopa raducristianpopa marked this pull request as ready for review July 14, 2024 06:55
sidvishnoi
sidvishnoi approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think we should first address #420 (comment)

@sidvishnoi sidvishnoi changed the title feat(background): store and send last monetization when starting an overpaying session feat(background): resend last monetization event on page refresh when overpaying Jul 15, 2024
@sidvishnoi sidvishnoi changed the title feat(background): resend last monetization event on page refresh when overpaying feat(background): resend last monetization event on reload when overpaying Jul 15, 2024
@raducristianpopa
Copy link
Member Author

LGTM, but I think we should first address #420 (comment)

Yep, thought it will be good to have this is so we won't forget about it.

@raducristianpopa raducristianpopa merged commit d74695d into main Jul 15, 2024
8 checks passed
@raducristianpopa raducristianpopa deleted the rp/422/overpaying-event branch July 15, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidvishnoi sidvishnoi sidvishnoi approved these changes

@dianafulga dianafulga Awaiting requested review from dianafulga

Assignees
No one assigned
Labels
area: background Improvements or additions to extension background script area: content Improvements or additions to extension content script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store and send last sent monetization event when overpaying
2 participants
@raducristianpopa @sidvishnoi