Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(background/storage): allow extension be in multiple states #393

Merged
merged 5 commits into from
Jul 5, 2024
Merged

fix(background/storage): allow extension be in multiple states #393

merged 5 commits into from
Jul 5, 2024

Conversation

sidvishnoi
Copy link
Member

Context

Closes #392

Changes proposed in this pull request

@github-actions github-actions bot added area: background Improvements or additions to extension background script area: popup Improvements or additions to extension popup labels Jul 5, 2024
@raducristianpopa
Copy link
Member

raducristianpopa commented Jul 5, 2024 •
edited
Loading

Extension builds preview

Name Link
Latest commit 579b061
Latest job logs Run #9809446462
BadgeDownload
BadgeDownload

@sidvishnoi
Copy link
Member Author

Unsure about the null optimization. I think can cause issues with race conditions. I think I won't set it in setStorage, but can make use of it in more synchronous operations.

@github-actions github-actions bot added the area: tests Improvements or additions to tests label Jul 5, 2024
raducristianpopa
raducristianpopa reviewed Jul 5, 2024
View reviewed changes
src/background/services/storage.ts Outdated Show resolved Hide resolved
src/background/services/storage.ts Outdated Show resolved Hide resolved
src/shared/helpers.ts Show resolved Hide resolved
@sidvishnoi sidvishnoi merged commit 3beb361 into main Jul 5, 2024
8 checks passed
@sidvishnoi sidvishnoi deleted the state-as-object branch July 5, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raducristianpopa raducristianpopa raducristianpopa approved these changes

Assignees
No one assigned
Labels
area: background Improvements or additions to extension background script area: popup Improvements or additions to extension popup area: tests Improvements or additions to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK] allow extension to be in simultaenous states
2 participants
@sidvishnoi @raducristianpopa