fix(content): dispatch load event if wallet address is valid
#367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area: content
Extension builds preview
|
){kind=icon}
){kind=icon}
raducristianpopa
force-pushed
the
rp/365/trigger-load-event
branch
from
8355b5c
to
7c7f142
Compare
sidvishnoi
reviewed
Jun 25, 2024
| `SPSP endpoint must be specified as ${spec}fully resolved https:// url, ` + | ||
| `got ${JSON.stringify(pointerOrUrl)} ` | ||
| url = new URL(walletAddressUrl) | ||
| if (url.protocol !== 'https:') { |
There was a problem hiding this comment.
Suggested change
| if (url.protocol !== 'https:') { | |
| if (!ALLOWED_PROTOCOLS.includes(url.protocol)) { |
There was a problem hiding this comment.
The wallet address should always be served under https:.
There was a problem hiding this comment.
I meant if in dev we want to use a localhost Rafiki.
sidvishnoi
reviewed
Jun 25, 2024
sidvishnoi
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes #365.
Changes proposed in this pull request
Initially I thought there was an error and the
loadevent was not correctly dispatched. It looks like we omitted this. Now we dispatch theloadevent if the wallet address is valid.Additional changes:
checkWalletAddressUrlFormatfunction since we do not need to check for SPSP endpoints