Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(background): ensure not to pay before interval, even on page reload #349

Merged
merged 16 commits into from
Jul 2, 2024
Merged

fix(background): ensure not to pay before interval, even on page reload #349

merged 16 commits into from
Jul 2, 2024

Conversation

dianafulga
Copy link
Contributor

@dianafulga dianafulga commented Jun 18, 2024 •
edited by sidvishnoi
Loading

Closes #286
Closes #287

@dianafulga dianafulga changed the title Overpaying fix: Overpaying Jun 18, 2024
@github-actions github-actions bot added the area: background Improvements or additions to extension background script label Jun 18, 2024
@dianafulga dianafulga changed the title fix: Overpaying feat: Overpaying Jun 18, 2024
@dianafulga dianafulga linked an issue Jun 18, 2024 that may be closed by this pull request
[Background] Overpaying #286
Closed
@dianafulga dianafulga requested review from sidvishnoi and raducristianpopa and removed request for sidvishnoi June 18, 2024 21:09
sidvishnoi
sidvishnoi reviewed Jun 19, 2024
View reviewed changes
src/background/utils.ts Outdated Show resolved Hide resolved
@raducristianpopa
Copy link
Member

raducristianpopa commented Jun 20, 2024 •
edited
Loading

Extension builds preview

Name Link
Latest commit 96993f0
Latest job logs Run #9759825370
BadgeDownload
BadgeDownload

@sidvishnoi sidvishnoi changed the title feat: Overpaying fix(background): ensure payment isn't made before interval, even on page reload Jun 20, 2024
@sidvishnoi sidvishnoi changed the title fix(background): ensure payment isn't made before interval, even on page reload fix(background): ensure not to pay before interval, even on page reload Jun 20, 2024
sidvishnoi
sidvishnoi reviewed Jun 20, 2024
View reviewed changes
src/background/utils.ts Outdated Show resolved Hide resolved
raducristianpopa
raducristianpopa reviewed Jul 1, 2024
View reviewed changes
src/background/services/tabState.ts Outdated Show resolved Hide resolved
src/background/services/tabState.ts Outdated Show resolved Hide resolved
src/background/services/tabState.ts Outdated Show resolved Hide resolved
src/background/services/tabState.ts Outdated Show resolved Hide resolved
src/background/services/paymentSession.ts Outdated Show resolved Hide resolved
src/background/services/tabState.ts Outdated Show resolved Hide resolved
sidvishnoi
sidvishnoi reviewed Jul 1, 2024
View reviewed changes
src/background/utils.ts Outdated Show resolved Hide resolved
sidvishnoi
sidvishnoi reviewed Jul 1, 2024
View reviewed changes
src/background/services/tabState.ts Outdated Show resolved Hide resolved
src/background/services/tabState.ts Outdated Show resolved Hide resolved
src/background/services/tabState.ts Outdated Show resolved Hide resolved
src/background/services/tabState.ts Show resolved Hide resolved
raducristianpopa
raducristianpopa reviewed Jul 2, 2024
View reviewed changes
src/background/utils.ts Outdated Show resolved Hide resolved
src/background/services/tabState.ts Outdated Show resolved Hide resolved
src/background/services/paymentSession.ts Show resolved Hide resolved
sidvishnoi
sidvishnoi requested changes Jul 2, 2024
View reviewed changes
Copy link
Member

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly that state-always-defined bug need resolved.

src/background/services/tabState.ts Outdated Show resolved Hide resolved
src/background/services/tabState.ts Outdated Show resolved Hide resolved
src/background/services/tabState.ts Show resolved Hide resolved
src/background/utils.ts Outdated Show resolved Hide resolved
src/background/utils.ts Outdated Show resolved Hide resolved
src/shared/types.ts Outdated Show resolved Hide resolved
@dianafulga dianafulga merged commit 9a51650 into main Jul 2, 2024
8 checks passed
@dianafulga dianafulga deleted the df--overpaying branch July 2, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidvishnoi sidvishnoi sidvishnoi approved these changes

@raducristianpopa raducristianpopa Awaiting requested review from raducristianpopa

Assignees
No one assigned
Labels
area: background Improvements or additions to extension background script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Background] [TO REFINE] Clear outdated data regarding overpaying [Background] Overpaying
3 participants
@dianafulga @raducristianpopa @sidvishnoi