Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update README #188

Merged
merged 6 commits into from
Apr 3, 2024
Merged

chore: update README #188

merged 6 commits into from
Apr 3, 2024

Conversation

raducristianpopa
Copy link
Member

@raducristianpopa raducristianpopa commented Mar 15, 2024

Context

Closes #170.

Changes proposed in this pull request

To be merged after #184.

@github-actions github-actions bot added the area: documentation Improvements or additions to documentation label Mar 15, 2024
@raducristianpopa
Copy link
Member Author

raducristianpopa commented Mar 15, 2024

Extension builds preview

Name Link
Latest commit ee22858
Latest job logs Run #8343680482
BadgeDownload
BadgeDownload
BadgeDownload
BadgeDownload

@raducristianpopa raducristianpopa marked this pull request as ready for review March 18, 2024 12:42
ionutanin
ionutanin previously approved these changes Mar 19, 2024
README.md Outdated

![Github Actions CI](https://github.com/interledger/web-monetization-extension/actions/workflows/sanity.yml/badge.svg?branch=main)
[![Prettier](https://img.shields.io/badge/code_style-prettier-ff69b4.svg?style=flat-square)](https://prettier.io/)

</center>
Web Monetization is a browser extension that detects Web Monetization on websites using a browser API that allows the
Copy link

@tselit tselit Mar 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting rewording:
The Web Monetization browser extension is an open source implementation of the Web Monetization draft specification - learn more here. The extension is built with React and TypeScript.

This extension detects whether a user is focused on a website that is Web Monetization enabled, and then makes it possible for the user to decide if they want to streaming payments from the user's authorized digital wallet to the website.

@@ -1,103 +1,125 @@
## Web Monetization Extension
<h1 align="center">Web Monetization Extension</h1>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you want to do <h1 text-align="center">Web Monetization Extension</h1>?

Copy link
Member Author

@raducristianpopa raducristianpopa Mar 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md Outdated Show resolved Hide resolved
Copy link

@tselit tselit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thanks Radu.

@raducristianpopa raducristianpopa merged commit 2376e15 into main Apr 3, 2024
9 checks passed
@raducristianpopa raducristianpopa deleted the rp--readme branch April 3, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update README
4 participants