WIP(loans): allow redeems to use reserve cash #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-savu
changed the title
daniel-savu
force-pushed
the
loans-reserve-is-cash
branch
from
1f5ad9d
to
b57f960
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental feature inspired by Compound V2 to allow redeems to use reserve cash when market utilization is too high to exit using user deposits. Note that unlike Compound V2, borrows are still not allowed to use reserve cash, because the point is to allow users to exit their lend token position rather than create more positions.
The side effect of this feature is that market utilization no longer has an upper bound of 100% and can be infinite.
Compound source:
getCashPrior() > redeemAmount: https://github.com/compound-finance/compound-protocol/blob/a3214f67b73310d547e00fc578e8355911c9d376/contracts/CToken.sol#L518getCashPrioris the entire balance of the contract: https://github.com/compound-finance/compound-protocol/blob/a3214f67b73310d547e00fc578e8355911c9d376/contracts/CToken.sol#L1125