feat: consume dia fair price feed #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Hill <[email protected]>
sander2
reviewed
Aug 30, 2023
sander2
reviewed
Aug 30, 2023
Signed-off-by: Gregory Hill <[email protected]>
gregdhill
force-pushed
the
feat/oracle-xlsd
branch
from
cf9d5b6
to
02edc4e
Compare
gregdhill
commented
Aug 30, 2023
oracle/examples/kintsugi-config.json
Outdated
| [ | ||
| { | ||
| "symbol": "BTC", | ||
| "alias": "KBTC" |
There was a problem hiding this comment.
The current architecture assumes we use the same price feed for all currency pairs, to avoid overhauling the oracle client I'm assuming it is okay to use the KBTC DIA xLSD price feed for BTC.
sander2
reviewed
Aug 30, 2023
| value | ||
| .as_array()? | ||
| .into_iter() | ||
| .find(|entry| matches!(entry.get("Token").and_then(|value| value.as_str()), Some(token) if token.to_uppercase() == alias))? |
There was a problem hiding this comment.
should we do alias to uppercase as well?
There was a problem hiding this comment.
The oracle config already assumes all token symbols are capitalized, if this is not the case then many parts of the code would not work correctly.
Signed-off-by: Gregory Hill <[email protected]>
sander2
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the oracle to be configured to fetch prices from the liquid-staking token feed here: https://www.diadata.org/app/liquid-staking/
There is only one breaking change to existing oracle configs, all DIA price feeds are quoted in USD so it may be required to switch the order e.g. from
["USD", "BTC=xxx"]to["BTC=xxx", "USD"].