Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Decode] Remove av1 decode from feature list on some platforms #1853

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

Jexu
Copy link
Contributor

@Jexu Jexu commented Sep 19, 2024

Fixes: #1852, #1832
Av1 decode needs filmgrain kernel support, and free kernel build will not support av1 decode.

@Jexu Jexu added AV1 AV1 Decode video decode related labels Sep 19, 2024
Fixes: intel#1852, intel#1832
Av1 decode needs filmgrain kernel support, and free kernel build will
not support av1 decode.

Signed-off-by: Xu, Zhengguo <[email protected]>
Copy link
Contributor

@Sherry-Lin Sherry-Lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Sherry-Lin Sherry-Lin added the verifying PR: fix ready and verifying with build/test label Sep 20, 2024
@nyanmisaka
Copy link
Contributor

nyanmisaka commented Sep 28, 2024

.adv0Decoding   = SET_STATUS_BY_FULL_OPEN_SOURCE(1, 0),
.adv1Decoding   = SET_STATUS_BY_FULL_OPEN_SOURCE(1, 0),

Wouldn't it be more intuitive to set these to media_driver/linux/{gen12,Xe_M}/ddi/media_sku_wa_{g12,xe}.cpp?

This would make libva not report AV1 decoding support in the so-called "free" driver, instead of crashing the video player or libavcodec when vaapi decoding is invoked. So as the downstream can fallback to using the software decoder gracefully.

mpv-player/mpv#14941

@okias
Copy link

okias commented Oct 1, 2024

@Jexu ^ + https://trac.ffmpeg.org/ticket/11213 . IMHO Avoiding the crash itself should be part of the change.

@intel-mediadev intel-mediadev merged commit 725f3bf into intel:master Oct 11, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AV1 AV1 Decode video decode related verifying PR: fix ready and verifying with build/test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: AV1 decoding fails with free kernel, works with non-free
5 participants